You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/03/06 10:55:55 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #106: fix scala-steward configuration
jrudolph opened a new pull request, #106:
URL: https://github.com/apache/incubator-pekko-http/pull/106
Even if not in use right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #106: fix scala-steward configuration
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #106:
URL: https://github.com/apache/incubator-pekko-http/pull/106#discussion_r1126248196
##########
.scala-steward.conf:
##########
@@ -4,14 +4,14 @@ pullRequests.frequency = "0 0 ? * 1"
commits.message = "build: update ${artifactName} from ${currentVersion} to ${nextVersion}"
updates.ignore = [
- { groupId = "com.typesafe.akka", artifactId = "akka-actor" },
- { groupId = "com.typesafe.akka", artifactId = "akka-actor-typed" },
- { groupId = "com.typesafe.akka", artifactId = "akka-stream" },
- { groupId = "com.typesafe.akka", artifactId = "akka-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-actor-testkit-typed" },
- { groupId = "com.typesafe.akka", artifactId = "akka-stream-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-multi-node-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-http" },
+ { groupId = "com.apache.pekko", artifactId = "pekko-actor" },
Review Comment:
groupId should be `org.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #106: fix scala-steward configuration
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #106:
URL: https://github.com/apache/incubator-pekko-http/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #106: fix scala-steward configuration
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #106:
URL: https://github.com/apache/incubator-pekko-http/pull/106#discussion_r1126266351
##########
.scala-steward.conf:
##########
@@ -4,14 +4,14 @@ pullRequests.frequency = "0 0 ? * 1"
commits.message = "build: update ${artifactName} from ${currentVersion} to ${nextVersion}"
updates.ignore = [
- { groupId = "com.typesafe.akka", artifactId = "akka-actor" },
- { groupId = "com.typesafe.akka", artifactId = "akka-actor-typed" },
- { groupId = "com.typesafe.akka", artifactId = "akka-stream" },
- { groupId = "com.typesafe.akka", artifactId = "akka-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-actor-testkit-typed" },
- { groupId = "com.typesafe.akka", artifactId = "akka-stream-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-multi-node-testkit" },
- { groupId = "com.typesafe.akka", artifactId = "akka-http" },
+ { groupId = "com.apache.pekko", artifactId = "pekko-actor" },
Review Comment:
Thanks, stupid :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org