You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/17 15:51:53 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request #2572: Migrate MockShell to junit5
DomGarguilo opened a new pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572
#2545 migrated the test module from JUnit4 to JUnit5. This class must have slipped through the cracks somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572#issuecomment-1071022457
We're only using it for the assertion checks, not running tests here. So, I'm not surprised it still worked, but I am surprised that JUnit4 was still on the class path somehow for this module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572#issuecomment-1071025073
> but I am surprised that JUnit4 was still on the class path somehow for this module.
Me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572#issuecomment-1071022457
We're only using it for the assertion checks, not running tests here. So, I'm not surprised it still worked, but I am surprised that JUnit4 was still on the class path somehow for this module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2572: Migrate MockShell to junit5
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #2572:
URL: https://github.com/apache/accumulo/pull/2572#issuecomment-1071025073
> but I am surprised that JUnit4 was still on the class path somehow for this module.
Me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org