You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/14 12:24:45 UTC

[GitHub] [spark] shahar603 commented on pull request #30374: [WIP][SPARK-33444][ML] Added support for Initial model in Gaussian Mixture Model in ML

shahar603 commented on pull request #30374:
URL: https://github.com/apache/spark/pull/30374#issuecomment-727200260


   The reason the tests fails is due `Param[GaussianMixtureModel]`. GaussianMixtureModel cannot be serializable using `jsonEncoder`.
   
   mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala
   
   So when the code tries to save/load the model, it fails because it can't serialize the GaussianMixtureModel object. Is there a way to fix this without changing the implementation of`jsonEncoder`? I believe changing `jsonEncoder` is beyond the scope of this PR and might require a new issue. What do you suggest?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org