You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/12/11 16:43:26 UTC
[GitHub] [avro] jturkel commented on a change in pull request #1037: AVRO-2999: Optimize Ruby union encoding
jturkel commented on a change in pull request #1037:
URL: https://github.com/apache/avro/pull/1037#discussion_r541079758
##########
File path: lang/ruby/lib/avro/schema_validator.rb
##########
@@ -62,12 +70,11 @@ def to_s
TypeMismatchError = Class.new(ValidationError)
class << self
- def validate!(expected_schema, logical_datum, options = { recursive: true, encoded: false, fail_on_extra_fields: false })
+ def validate!(expected_schema, logical_datum, options = DEFAULT_VALIDATION_OPTIONS)
options ||= {}
Review comment:
I think we should remove this line since I don't see the value in letting clients explicitly pass a nil `options` hash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org