You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/26 19:06:18 UTC

[jira] [Commented] (THRIFT-3677) Improve CMake Java build

    [ https://issues.apache.org/jira/browse/THRIFT-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169443#comment-15169443 ] 

ASF GitHub Bot commented on THRIFT-3677:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/897

    THRIFT-3677 Improve CMake Java build

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3677

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/897.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #897
    
----
commit d7b7a3742966e2f07c948fc97f804154c7c29d3d
Author: Nobuaki Sukegawa <ns...@apache.org>
Date:   2016-02-26T18:04:34Z

    THRIFT-3677 Improve CMake Java build

----


> Improve CMake Java build
> ------------------------
>
>                 Key: THRIFT-3677
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3677
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process, Java - Library
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Minor
>
> * enable code generation and test
> * remove erroneous "work.dir" argument that was failing on Windows
> * rebuild iff sources are updated
> * quote paths in ant command invokation to allow spaces in paths
> * add to Appveyor build (Maybe not so useful. Jar can be reliably built on Linux)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)