You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/11/28 17:12:31 UTC
Review Request 54132: Support configurable grok filters (output +
ambari)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54132/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-19001
https://issues.apache.org/jira/browse/AMBARI-19001
Repository: ambari
Description
-------
adding configurable ambari and output configs.
also update usage of logfeeder kerberos related properties (like set the jaas file if its needed) -> these changes make it possible to use new outputs for logfeeder. (e.g. kafka or hdfs)
Diffs
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f00b1eb
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 ad4adb2
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/input.config-ambari.json.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 PRE-CREATION
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 773b75a
ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53
Diff: https://reviews.apache.org/r/54132/diff/
Testing
-------
tests updated.
Total run:1163
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:21.865s
[INFO] Finished at: Mon Nov 28 17:53:13 CET 2016
[INFO] Final Memory: 67M/1419M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 54132: Support configurable grok filters (output +
ambari)
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54132/#review157236
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Nov. 29, 2016, 12:46 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54132/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 12:46 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19001
> https://issues.apache.org/jira/browse/AMBARI-19001
>
>
> Repository: ambari
>
>
> Description
> -------
>
> adding configurable ambari and output configs.
>
> also update usage of logfeeder kerberos related properties (like set the jaas file if its needed) -> these changes make it possible to use new outputs for logfeeder. (e.g. kafka or hdfs)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f00b1eb
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 ad4adb2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/input.config-ambari.json.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 PRE-CREATION
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 773b75a
> ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53
>
> Diff: https://reviews.apache.org/r/54132/diff/
>
>
> Testing
> -------
>
> tests updated.
>
> Total run:1163
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:21.865s
> [INFO] Finished at: Mon Nov 28 17:53:13 CET 2016
> [INFO] Final Memory: 67M/1419M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 54132: Support configurable grok filters (output +
ambari)
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54132/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 12:46 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
updated descriptions
Bugs: AMBARI-19001
https://issues.apache.org/jira/browse/AMBARI-19001
Repository: ambari
Description
-------
adding configurable ambari and output configs.
also update usage of logfeeder kerberos related properties (like set the jaas file if its needed) -> these changes make it possible to use new outputs for logfeeder. (e.g. kafka or hdfs)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f00b1eb
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 ad4adb2
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/input.config-ambari.json.j2 PRE-CREATION
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 PRE-CREATION
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 773b75a
ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53
Diff: https://reviews.apache.org/r/54132/diff/
Testing
-------
tests updated.
Total run:1163
Total errors:0
Total failures:0
OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:21.865s
[INFO] Finished at: Mon Nov 28 17:53:13 CET 2016
[INFO] Final Memory: 67M/1419M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 54132: Support configurable grok filters (output +
ambari)
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54132/#review157094
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Nov. 28, 2016, 5:12 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54132/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 5:12 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19001
> https://issues.apache.org/jira/browse/AMBARI-19001
>
>
> Repository: ambari
>
>
> Description
> -------
>
> adding configurable ambari and output configs.
>
> also update usage of logfeeder kerberos related properties (like set the jaas file if its needed) -> these changes make it possible to use new outputs for logfeeder. (e.g. kafka or hdfs)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f00b1eb
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 ad4adb2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/input.config-ambari.json.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 PRE-CREATION
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 773b75a
> ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53
>
> Diff: https://reviews.apache.org/r/54132/diff/
>
>
> Testing
> -------
>
> tests updated.
>
> Total run:1163
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:21.865s
> [INFO] Finished at: Mon Nov 28 17:53:13 CET 2016
> [INFO] Final Memory: 67M/1419M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 54132: Support configurable grok filters (output +
ambari)
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54132/#review157233
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml (line 26)
<https://reviews.apache.org/r/54132/#comment227766>
This configuration contains not only grok filters, but also file locations, other filters, and mappings. The description is misleading.
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml (line 26)
<https://reviews.apache.org/r/54132/#comment227767>
Output contains no grok at all, change the description.
- Miklos Gergely
On Nov. 28, 2016, 5:12 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54132/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 5:12 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-19001
> https://issues.apache.org/jira/browse/AMBARI-19001
>
>
> Repository: ambari
>
>
> Description
> -------
>
> adding configurable ambari and output configs.
>
> also update usage of logfeeder kerberos related properties (like set the jaas file if its needed) -> these changes make it possible to use new outputs for logfeeder. (e.g. kafka or hdfs)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml f00b1eb
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py bdb0c10
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py 021c167
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2 ad4adb2
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2 ff43323
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/input.config-ambari.json.j2 PRE-CREATION
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 PRE-CREATION
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 773b75a
> ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53
>
> Diff: https://reviews.apache.org/r/54132/diff/
>
>
> Testing
> -------
>
> tests updated.
>
> Total run:1163
> Total errors:0
> Total failures:0
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:21.865s
> [INFO] Finished at: Mon Nov 28 17:53:13 CET 2016
> [INFO] Final Memory: 67M/1419M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>