Re: [PR] refactor: Removing type infromation in `Struct` literal. [iceberg-rust]

["mobley-trent (via GitHub)" <gi...@apache.org>]

mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1400115507


##########
crates/iceberg/src/spec/values.rs:
##########
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
                 PrimitiveLiteral::Decimal(_) => todo!(),
             },
             Literal::Struct(s) => {

Review Comment:
   Hey @liurenjie1024 how should we design this method ? Since the iterator only return the value instead of the `(id, value, name)` tuple. I'm having trouble setting up the test for this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org