You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/01/30 01:10:15 UTC
[GitHub] [geode] kirklund opened pull request #3137: GEODE-6334:
Create CachePerfStatsTest and cleanup CachePerfStats
Cleaned up some minor warnings in CachePerfStats and wrote unit tests for all CachePerfStats operation count stats that are currently implemented as IntCounters which can wrap from max integer to negative values.
Please review @mhansonp @demery-pivotal
[ Full content available at: https://github.com/apache/geode/pull/3137 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3137: GEODE-6334:
Create CachePerfStatsTest and cleanup CachePerfStats
Posted by "kirklund (GitHub)" <gi...@apache.org>.
ImportClusterConfigTest failed but does not have an open Jira ticket. I don't believe this test failed due to CachePerfStats changes.
[ Full content available at: https://github.com/apache/geode/pull/3137 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3137: GEODE-6334:
Create CachePerfStatsTest and cleanup CachePerfStats
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3137 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on issue #3137: GEODE-6334: Create
CachePerfStatsTest and cleanup CachePerfStats
Posted by "moleske (GitHub)" <gi...@apache.org>.
The DistributedTestOpenJDK11 [failure](http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-3137/test-results/distributedTest/1548875823/) seems to be [GEODE-4267](https://issues.apache.org/jira/browse/GEODE-4267) so pushing an empty commit to retrigger
[ Full content available at: https://github.com/apache/geode/pull/3137 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] demery-pivotal commented on pull request #3137:
GEODE-6334: Create CachePerfStatsTest and cleanup CachePerfStats
Posted by "demery-pivotal (GitHub)" <gi...@apache.org>.
This looks like a characterization test (demonstrating what the code currently does) rather than a test of what we really want it to do. Consider mentioning that in a comment. Similar for the other "wraps to negative" tests.
[ Full content available at: https://github.com/apache/geode/pull/3137 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org