You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2023/03/05 23:53:37 UTC
[impala] 01/02: IMPALA-11965: Fix TestCodegenCache failure when codegen cache disabled by default
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit e15610633e5170559b6a0dd3cad10be1de0ebcd8
Author: Yida Wu <yi...@cloudera.com>
AuthorDate: Thu Mar 2 17:16:23 2023 -0800
IMPALA-11965: Fix TestCodegenCache failure when codegen cache disabled by default
The patch fixes the testcase TestCodegenCache failure when the codegen
cache is changed to be disabled by default, because the testcase
assumes the codegen cache is enabled with the default setting.
The solution is to specify a default value to codegen_cache_capacity
in the testcase's start option, so that manually ensures the
codegen cache is on during the test.
Tests:
Passed TestCodegenCache in the exhaustive run with codegen cache
disabled by default.
Change-Id: I749a6ba68553834bdea908741aa7449ed32cd569
Reviewed-on: http://gerrit.cloudera.org:8080/19574
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/custom_cluster/test_codegen_cache.py | 45 ++++++++++++++++++++----------
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/tests/custom_cluster/test_codegen_cache.py b/tests/custom_cluster/test_codegen_cache.py
index f867fb378..bdd69c614 100644
--- a/tests/custom_cluster/test_codegen_cache.py
+++ b/tests/custom_cluster/test_codegen_cache.py
@@ -40,76 +40,88 @@ class TestCodegenCache(CustomClusterTestSuite):
super(TestCodegenCache, cls).setup_class()
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache(self, vector):
self._test_codegen_cache(vector,
("select * from (select * from functional.alltypes "
+ "limit 1000000) t1 where int_col > 10 limit 10"))
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_int_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where int_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_tinyint_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where tinyint_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_bool_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where bool_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_bigint_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where bigint_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_float_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where float_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_double_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where double_col > 0")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_date_string_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where date_string_col != ''")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_string_col(self, vector):
self._test_codegen_cache(vector,
"select * from functional.alltypes where string_col != ''")
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_poly_func_string_col(self, vector):
self._test_codegen_cache(vector,
("select * from functional.alltypes where "
+ "CHAR_LENGTH(string_col) > 0"))
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_poly_func_date_string_col(self, vector):
self._test_codegen_cache(vector,
("select * from functional.alltypes where "
+ "CHAR_LENGTH(date_string_col) > 0"))
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
# Test native uda is missed in the codegen cache, as it is disabled.
def test_codegen_cache_uda_miss(self, vector):
database = "test_codegen_cache_uda_miss"
@@ -118,7 +130,8 @@ class TestCodegenCache(CustomClusterTestSuite):
"select test_count(int_col) from functional.alltypestiny", False)
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
# Test native udf is missed in the codegen cache, as it is disabled.
def test_codegen_cache_udf_miss(self, vector):
database = "test_codegen_cache_udf_miss"
@@ -193,7 +206,8 @@ class TestCodegenCache(CustomClusterTestSuite):
assert result is not None
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=3)
+ @CustomClusterTestSuite.with_args(cluster_size=3,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_udf_crash(self, vector):
# The testcase would crash if we don't disable the native udf for codegen cache.
database = "test_codegen_cache_udf_crash"
@@ -234,7 +248,8 @@ class TestCodegenCache(CustomClusterTestSuite):
assert result is not None
@pytest.mark.execute_serially
- @CustomClusterTestSuite.with_args(cluster_size=1)
+ @CustomClusterTestSuite.with_args(cluster_size=1,
+ impalad_args="--codegen_cache_capacity=1GB")
def test_codegen_cache_timezone_crash(self, vector):
# The testcase tests whether it would crash using the broken builtin function
# from_utc_timestamp from the codegen cache.