[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4320: feat: add PageInOrder to support request pages one by one

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on code in PR #4320:
URL: https://github.com/apache/incubator-devlake/pull/4320#discussion_r1095659740


##########
backend/helpers/pluginhelper/api/api_collector.go:
##########
@@ -208,13 +212,43 @@ func (collector *ApiCollector) exec(input interface{}) {
 	}
 	if collector.args.PageSize <= 0 {
 		collector.fetchAsync(reqData, nil)
+	} else if collector.args.PageInOrder {
+		collector.fetchPagesInOrder(reqData)
 	} else if collector.args.GetTotalPages != nil {
 		collector.fetchPagesDetermined(reqData)
 	} else {
 		collector.fetchPagesUndetermined(reqData)
 	}
 }
 
+// fetchPagesInOrder fetches data of all pages in order to build query by prev response
+func (collector *ApiCollector) fetchPagesInOrder(reqData *RequestData) {

Review Comment:
   How about `fetchPagesSequentially`?



##########
backend/helpers/pluginhelper/api/api_collector.go:
##########
@@ -208,13 +212,43 @@ func (collector *ApiCollector) exec(input interface{}) {
 	}
 	if collector.args.PageSize <= 0 {
 		collector.fetchAsync(reqData, nil)
+	} else if collector.args.PageInOrder {

Review Comment:
   I think we may define a `GetNextPagerUrl` function on par with `GetTotalPages`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org