You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/12/26 19:32:03 UTC
[GitHub] [zeppelin] fred521 opened a new pull request #3571: add angular
support for jetty
fred521 opened a new pull request #3571: add angular support for jetty
URL: https://github.com/apache/zeppelin/pull/3571
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: add angular support for
jetty
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: add angular support for jetty
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569176130
Thanks for the contribution @fred521
Could you create a ticket for it ? And Do you want to contribute your presto note tutorial to Zeppelin ? 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: [ZEPPELIN-4515] Have
Jetty Server support multiple wars
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: [ZEPPELIN-4515] Have Jetty Server support multiple wars
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569856534
@fred521 I tried this PR, but could not open the new angular ui. Anything else need to configure ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: [ZEPPELIN-4515] Have
Jetty Server support multiple wars
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: [ZEPPELIN-4515] Have Jetty Server support multiple wars
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-570437555
Thanks @fred521 LGTM , will merge if no more comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: [ZEPPELIN-4515] Have
Jetty Server support multiple wars
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: [ZEPPELIN-4515] Have Jetty Server support multiple wars
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-571499225
@fred521 I have merged it, could you close this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: add angular support for
jetty
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: add angular support for jetty
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569394226
@fred521 Could you update the PR title and description, please follow the contribution guildeline here. http://zeppelin.apache.org/community.html
Regarding the presto, I mean you added presto note in this PR. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3571: [ZEPPELIN-4515] Have
Jetty Server support multiple wars
Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3571: [ZEPPELIN-4515] Have Jetty Server support multiple wars
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569858743
@fred521 I can make it work by changing this line to following https://github.com/apache/zeppelin/pull/3571/files#diff-179ea3a816210bb9904baabec1a552e4R825
```
ZEPPELIN_ANGULAR_WAR("zeppelin.angular.war", "zeppelin-web-angular/dist/zeppelin"),
```
Thanks @hsuanxyz for the hint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] fred521 closed pull request #3571: [ZEPPELIN-4515] Have
Jetty Server support multiple wars
Posted by GitBox <gi...@apache.org>.
fred521 closed pull request #3571: [ZEPPELIN-4515] Have Jetty Server support multiple wars
URL: https://github.com/apache/zeppelin/pull/3571
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] fred521 commented on issue #3571: add angular support
for jetty
Posted by GitBox <gi...@apache.org>.
fred521 commented on issue #3571: add angular support for jetty
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569363206
> Thanks for the contribution @fred521
> Could you create a ticket for it ? And Do you want to contribute your presto note tutorial to Zeppelin ? 😄
add the Jira link to the PR.
Would love to share anything, presto note tutorial means presto notebook that created by our users ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] fred521 commented on issue #3571: add angular support
for jetty
Posted by GitBox <gi...@apache.org>.
fred521 commented on issue #3571: add angular support for jetty
URL: https://github.com/apache/zeppelin/pull/3571#issuecomment-569397840
> Regarding the presto, I mean you added presto note in this PR. 😄
haha, that was a mistake, thanks 😄😄😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services