[GitHub] [hive] deniskuzZ commented on a change in pull request #3000: HIVE-25915: Query based MINOR compaction fails with NPE if the data is loaded into the ACID table

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #3000:
URL: https://github.com/apache/hive/pull/3000#discussion_r800430818



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -242,6 +242,7 @@ private void scheduleCompactionIfRequired(CompactionInfo ci, Table t, Partition
     try {
       ValidWriteIdList validWriteIds = resolveValidWriteIds(t);
       CompactionType type = checkForCompaction(ci, validWriteIds, sd, t.getParameters(), runAs);
+      ci.type = type;

Review comment:
       I don't think this is necessary as we are passing compaction type in the request method. Type is set on CompactionRequest object.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org