You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@labs.apache.org by si...@apache.org on 2009/09/15 10:49:25 UTC
svn commit: r815221 - in /labs/magma/trunk:
foundation-database/src/main/java/org/apache/magma/database/
foundation-validation/src/main/java/org/apache/magma/validation/
Author: simoneg
Date: Tue Sep 15 08:49:25 2009
New Revision: 815221
URL: http://svn.apache.org/viewvc?rev=815221&view=rev
Log:
LABS-168 : errors for wrong validation
Added:
labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj (contents, props changed)
- copied, changed from r735585, labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnAgainstBadUsage.aj
labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj (contents, props changed)
- copied, changed from r735585, labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnForWrongUsage.aj
Removed:
labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnAgainstBadUsage.aj
labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnForWrongUsage.aj
Copied: labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj (from r735585, labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnAgainstBadUsage.aj)
URL: http://svn.apache.org/viewvc/labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj?p2=labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj&p1=labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnAgainstBadUsage.aj&r1=735585&r2=815221&rev=815221&view=diff
==============================================================================
--- labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnAgainstBadUsage.aj (original)
+++ labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj Tue Sep 15 08:49:25 2009
@@ -16,7 +16,7 @@
*/
package org.apache.magma.database;
-public aspect WarnAgainstBadUsage {
+public aspect WarnDatabaseUsage {
declare warning : set(Database+ *.*) || get(Database+ *.*) : "Magma: Database should not be stored in a field, but instantiated when needed!";
Propchange: labs/magma/trunk/foundation-database/src/main/java/org/apache/magma/database/WarnDatabaseUsage.aj
------------------------------------------------------------------------------
svn:mergeinfo =
Copied: labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj (from r735585, labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnForWrongUsage.aj)
URL: http://svn.apache.org/viewvc/labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj?p2=labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj&p1=labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnForWrongUsage.aj&r1=735585&r2=815221&rev=815221&view=diff
==============================================================================
--- labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnForWrongUsage.aj (original)
+++ labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj Tue Sep 15 08:49:25 2009
@@ -17,8 +17,37 @@
package org.apache.magma.validation;
import org.apache.magma.beans.MagmaBeanSupport;
+import org.apache.magma.validation.validators.Email;
+import org.apache.magma.validation.validators.Length;
+import org.apache.magma.validation.validators.Regex;
+import org.apache.magma.validation.validators.Range;
+import org.apache.magma.validation.validators.FloatingPointRange;
+import org.apache.magma.beans.MagmaBeanSupport;
-public aspect WarnForWrongUsage {
+public aspect WarnValidatorsUsage {
+ declare error : execution(@(Email || Length || Regex) public !String MagmaBeanSupport+.get*()) : "Magma: This validation is applicable only to String properties";
+ declare error : execution(@(Email || Length || Regex) public void MagmaBeanSupport+.set*(!String)) : "Magma: This validation is applicable only to String properties";
+ declare error : execution(@(Range || FloatingPointRange) public * MagmaBeanSupport+.get*()) &&
+ !(
+ execution(int *.get*()) ||
+ execution(long *.get*()) ||
+ execution(short *.get*()) ||
+ execution(float *.get*()) ||
+ execution(double *.get*()) ||
+ execution(Number+ *.get*())
+ ) : "Magma: This validation is applicable only to numeric properties";
+
+ declare error : execution(@(Range || FloatingPointRange) public void MagmaBeanSupport+.set*(..)) &&
+ !(
+ execution(void *.set*(int)) ||
+ execution(void *.set*(long)) ||
+ execution(void *.set*(short)) ||
+ execution(void *.set*(float)) ||
+ execution(void *.set*(float)) ||
+ execution(void *.set*(Number+))
+ ) : "Magma: This validation is applicable only to numeric properties";
+
+
}
Propchange: labs/magma/trunk/foundation-validation/src/main/java/org/apache/magma/validation/WarnValidatorsUsage.aj
------------------------------------------------------------------------------
svn:mergeinfo =
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@labs.apache.org
For additional commands, e-mail: commits-help@labs.apache.org