You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/25 18:02:39 UTC
[GitHub] [superset] cccs-Dustin opened a new pull request, #19839: fix(dashboard): allow users to resize the markdown widget easier
cccs-Dustin opened a new pull request, #19839:
URL: https://github.com/apache/superset/pull/19839
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR was made to fix the issue where users were not easily able to resize the column width of the Markdown widget when editing a dashboard. From my investigation of the code, I found that there was indeed a container handle on the right side of a Markdown widget, it was just very narrow compared to the right side container handles of the other charts within a dashboard.
To fix this issue, I just needed to modify the `resizable.less` file so that `.resizable-container-handle--right` behaves the same way as `.resizable-container-handle--bottom`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
(The resize cursor is not easily selectable, as the handle to resize it is very narrow)
After:
(The resize cursor is now much easier to select, as the handle for it has been widened and is now the same size as the handle on the bottom of the widget)
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Go to a dashboard which contains a Markdown widget, or add a Markdown widget to a new or existing dashboard.
2. Select the "Edit dashboard" button (pencil icon in the top right of the page).
3. Try to adjust the width of the markdown widget.
4. You will notice that it is now much easier to select the resize handle compared to before the code changes.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/superset/issues/19838
- [ ] Required feature flags:
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cccs-Dustin commented on pull request #19839: fix(dashboard): allow users to resize the markdown widget easier
Posted by GitBox <gi...@apache.org>.
cccs-Dustin commented on PR #19839:
URL: https://github.com/apache/superset/pull/19839#issuecomment-1117634093
> this seems reasonable, assuming you've tested this for all charts/dashboard components (and not only markdown)
I tested with all of the charts/dashboard components. It seems to work correctly for all of them now, not just everything but the markdown component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #19839: fix(dashboard): allow users to resize the markdown widget easier
Posted by GitBox <gi...@apache.org>.
etr2460 merged PR #19839:
URL: https://github.com/apache/superset/pull/19839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19839: fix(dashboard): allow users to resize the markdown widget easier
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19839:
URL: https://github.com/apache/superset/pull/19839#issuecomment-1108926078
# [Codecov](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19839](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b643225) into [master](https://codecov.io/gh/apache/superset/commit/a1bd5b283cc3b766d54c7c61d6487b4bce7ce916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1bd5b2) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head b643225 differs from pull request most recent head b86c34e. Consider uploading reports for the commit b86c34e to get more accurate results
```diff
@@ Coverage Diff @@
## master #19839 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 1692 1692
Lines 64801 64802 +1
Branches 6657 6657
=======================================
+ Hits 43128 43129 +1
Misses 19973 19973
Partials 1700 1700
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.25% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/19839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.39% <ø> (ø)` | |
| [superset/utils/csv.py](https://codecov.io/gh/apache/superset/pull/19839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY3N2LnB5) | `97.67% <100.00%> (+0.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1bd5b2...b86c34e](https://codecov.io/gh/apache/superset/pull/19839?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org