[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2214: Add sort order to writer classes

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2214:
URL: https://github.com/apache/iceberg/pull/2214#discussion_r591990743



##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java
##########
@@ -159,6 +168,7 @@ private StructType lazyPosDeleteSparkType() {
               .withPartition(partition)
               .equalityFieldIds(equalityFieldIds)
               .withKeyMetadata(file.keyMetadata())
+              .withSortOrder(sortOrder)

Review comment:
       @yyanyy, I think we cannot mark files with the current sort order id by default as there is no guarantee the incoming records are sorted. If we had an API to request a specific distribution and ordering in a query engine (will be possible in Spark 3.2, for example), only then we could annotate the files.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org