You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by ishark <gi...@git.apache.org> on 2015/09/24 01:23:15 UTC
[GitHub] incubator-apex-core pull request: APEX-92 #Comment #resolve
GitHub user ishark opened a pull request:
https://github.com/apache/incubator-apex-core/pull/68
APEX-92 #Comment #resolve
Fix for adding failed nodes to blacklist, after failure is observed for the same node more than MAX number of tries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ishark/incubator-apex-core APEX-92
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 866fefd8e4ab64b852a3452b0a78c7c62b9c45e5
Author: ishark <is...@datatorrent.com>
Date: 2015-09-23T23:17:04Z
APEX-92 #Comment #resolve
Fix for adding failed nodes to blacklist, after failure is observed for the same node more than MAX number of tries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-92 #Comment #resolve
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/68#discussion_r40515573
--- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -651,6 +647,9 @@ private void execute() throws YarnException, IOException
int minVcores = conf.getInt("yarn.scheduler.minimum-allocation-vcores", 0);
LOG.info("Max mem {}m, Min mem {}m, Max vcores {} and Min vcores {} capabililty of resources in this cluster ", maxMem, minMem, maxVcores, minVcores);
+ int maxConsecutiveContainerFailures = conf.getInt("MAX_CONSECUTIVE_CONTAINER_FAILURES", MAX_CONTAINER_FAILURES_PER_NODE);
--- End diff --
This doesn't work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-92 #Comment #resolve
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEX-92 #Comment #resolve
Posted by ishark <gi...@git.apache.org>.
Github user ishark commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/68#discussion_r40620622
--- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
@@ -880,6 +883,20 @@ private void execute() throws YarnException, IOException
if (0 != exitStatus) {
if (allocatedContainer != null) {
numFailedContainers.incrementAndGet();
+ if (exitStatus != 1) {
+ // If container failure due to framework
+ AtomicInteger failedTimes = new AtomicInteger(1);
+ String hostname = allocatedContainer.container.getNodeId().getHost();
+ if (failedContainersMap.containsKey(hostname)) {
--- End diff --
ConcurrentMap is needed only if later down the line, we want to expose failure count per hostname as part of ClusterAppStats. Similar to getFailedContainers (returns total number of failures)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---