You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/27 16:07:49 UTC

[GitHub] [iceberg] nastra opened a new pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

nastra opened a new pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397


   The problem is that `./gradlew printVersion` is currently showing the
   branch name instead of the actual Iceberg version, because the version
   is being overwritten here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra edited a comment on pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

Posted by GitBox <gi...@apache.org>.
nastra edited a comment on pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397#issuecomment-953081187


   @rdblue I couldn't find any place that would depend on `project.rootProject.version` being set to the branch name. There are a few places further below that use the branch name and those all seem to do the correct thing, so I'm assuming that `project.rootProject.version = getJavadocVersion()` isn't needed, but wanted to verify with you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397#issuecomment-953079231


   If you remove this, then the version in Javadoc will be the project version. Is that something that we want to change? I guess we don't build Javadoc from branches much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue merged pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397#issuecomment-955762410


   Thanks, @nastra!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra commented on pull request #3397: Build: ./gradlew printVersion should print correct Iceberg version

Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #3397:
URL: https://github.com/apache/iceberg/pull/3397#issuecomment-953081187


   @rdblue I couldn't find any place what would depend on `project.rootProject.version` being set to the branch name. There are a few places further below that use the branch name and those all seem to do the correct thing, so I'm assuming that `project.rootProject.version = getJavadocVersion()` isn't needed, but wanted to verify with you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org