[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #49: Matrix build with many Maven versions

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #49:
URL: https://github.com/apache/maven-gh-actions-shared/pull/49#discussion_r913664764


##########
.github/workflows/maven-verify-test.yml:
##########
@@ -32,3 +32,4 @@ jobs:
       ff-goal: test
       verify-goal: clean install
       verify-fail-fast: false
+      maven-matrix: '[ "3.2.5", "3.8.6" ]'

Review Comment:
   t is only test workflow executed in this repo



##########
.github/workflows/maven-verify-test.yml:
##########
@@ -32,3 +32,4 @@ jobs:
       ff-goal: test
       verify-goal: clean install

Review Comment:
   it is only test workflow executed in this repo - show what happens when `ff-goal` and `verify-goal` have different commands



##########
.github/workflows/maven-verify-test.yml:
##########
@@ -17,7 +17,7 @@
 
 name: Verify - Test
 
-on: push
+on: [ push, pull_request ]

Review Comment:
   not 😄 



##########
.github/workflows/maven-verify.yml:
##########
@@ -20,54 +20,54 @@ name: Verify
 on:
   workflow_call:
     inputs:
-      maven_args:
+      maven-args:
         description: The arguments to pass to all Maven commands when building the code
         required: false
         default: '-D"invoker.streamLogsOnFailures"'
         type: string
 
-      maven_version:
-        description: The Maven version used for builds
-        required: false
-        default: '3.8.6'
-        type: string
-
       os-matrix:
-        description: 'os matrix as json array'
+        description: os matrix as json array
         required: false
         default: '[ "ubuntu-latest", "windows-latest", "macOS-latest" ]'
         type: string
 
       jdk-matrix:
-        description: 'jdk matrix as json array'
+        description: jdk matrix as json array
         required: false
         default: '[ "8", "11", "17" ]'
         type: string
 
+      jdk-distribution-matrix:
+        description: jdk distribution matrix
+        required: false
+        default: '[ "temurin" ]'
+        type: string
+
+      maven-matrix:
+        description: The Maven version matrix as json array
+        required: false
+        default: '[ "3.8.6" ]'
+        type: string
+
       matrix-exclude:
-        description: 'exclude for matrix as json'
+        description: exclude for matrix as json
         required: false
         default: '[]'
         type: string
 
       max-parallel:
-        description: 'max parallel jobs'
+        description: max parallel jobs
         required: false
         default: 100
         type: number
 
       timeout-minutes:
-        description: 'timeout-minutes used by the builds (defaults to 360)'
+        description: timeout-minutes used by the builds (defaults to 360)
         required: false
         default: 360
         type: number
 
-      jdk-distribution-matrix:

Review Comment:
   I grupped all `*-matrix` options together - it is preserved in line 41



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org