[GitHub] [incubator-superset] michellethomas opened a new pull request #7787: Updating legacy-plugin-chart-heatmap to fix an issue with heatmap

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #7787: Updating legacy-plugin-chart-heatmap to fix an issue with heatmap
URL: https://github.com/apache/incubator-superset/pull/7787
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Heatmap with null values errors with `An error occurred while rendering the visualization: TypeError: Cannot read property 'toString' of null` fixed the issue in superset-ui-plugins and updating to pick up that change.
   
   ### TEST PLAN
   Create heatmap for data where x or y field contains nulls
   Verify the chart has no errors
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org