[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6146: Make TM recover from TO being unavailable at startup

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #6146:
URL: https://github.com/apache/trafficcontrol/pull/6146#discussion_r698569173



##########
File path: traffic_monitor/handler/handler.go
##########
@@ -40,7 +40,6 @@ type OpsConfig struct {
 	HttpsListener string `json:"httpsListener"`
 	CertFile      string `json:"certFile"`
 	KeyFile       string `json:"keyFile"`
-	UsingDummyTO  bool   `json:"usingDummyTO"`

Review comment:
       Oh good catch! I didn't even think to look for usages of the json key.

##########
File path: traffic_monitor/towrap/towrap.go
##########
@@ -36,6 +39,7 @@ import (
 	"github.com/apache/trafficcontrol/traffic_monitor/config"
 	legacyClient "github.com/apache/trafficcontrol/traffic_ops/v2-client"
 	client "github.com/apache/trafficcontrol/traffic_ops/v3-client"
+	"golang.org/x/net/publicsuffix"
 
 	jsoniter "github.com/json-iterator/go"

Review comment:
       Agreed, will move.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org