You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/08/01 11:47:46 UTC
(commons-compress) branch master updated (06449cab6 -> 44706ad90)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
from 06449cab6 [COMPRESS-685] Update Javadoc description for GzipCompressorInputStream #551
new 082a58d57 Use StringBuilder(String)
new 0c56e6747 Use fluent style
new dbca295f5 Use fluent style
new ee90be6e8 Fix Javadoc error
new 2f562a41f Use StringUtils.repeat()
new 44706ad90 Use StringUtils.repeat()
The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../commons/compress/archivers/zip/X000A_NTFS.java | 18 ++++++++++++++----
.../compressors/gzip/GzipCompressorInputStream.java | 2 +-
.../commons/compress/harmony/unpack200/IcTuple.java | 18 ++++++++++--------
.../unpack200/bytecode/ExceptionsAttribute.java | 3 +--
.../org/apache/commons/compress/archivers/TarTest.java | 8 +++-----
.../commons/compress/archivers/tar/TarFileTest.java | 8 +++-----
6 files changed, 32 insertions(+), 25 deletions(-)
(commons-compress) 01/06: Use StringBuilder(String)
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 082a58d57494e464a90c4a33cb0094566fdfb029
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:32:53 2024 -0400
Use StringBuilder(String)
---
.../compress/harmony/unpack200/bytecode/ExceptionsAttribute.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/ExceptionsAttribute.java b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/ExceptionsAttribute.java
index 711dd5258..a1c068d63 100644
--- a/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/ExceptionsAttribute.java
+++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/ExceptionsAttribute.java
@@ -103,8 +103,7 @@ public class ExceptionsAttribute extends Attribute {
@Override
public String toString() {
- final StringBuilder sb = new StringBuilder();
- sb.append("Exceptions: ");
+ final StringBuilder sb = new StringBuilder("Exceptions: ");
for (final CPClass exception : exceptions) {
sb.append(exception);
sb.append(' ');
(commons-compress) 02/06: Use fluent style
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 0c56e674743378ecd98f29810007c7a694571d1e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:37:27 2024 -0400
Use fluent style
---
.../commons/compress/archivers/zip/X000A_NTFS.java | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/X000A_NTFS.java b/src/main/java/org/apache/commons/compress/archivers/zip/X000A_NTFS.java
index 36d844a17..d7f57392b 100644
--- a/src/main/java/org/apache/commons/compress/archivers/zip/X000A_NTFS.java
+++ b/src/main/java/org/apache/commons/compress/archivers/zip/X000A_NTFS.java
@@ -449,9 +449,19 @@ public class X000A_NTFS implements ZipExtraField {
*/
@Override
public String toString() {
- final StringBuilder buf = new StringBuilder();
- buf.append("0x000A Zip Extra Field:").append(" Modify:[").append(getModifyFileTime()).append("] ").append(" Access:[").append(getAccessFileTime())
- .append("] ").append(" Create:[").append(getCreateFileTime()).append("] ");
- return buf.toString();
+ // @formatter:off
+ return new StringBuilder()
+ .append("0x000A Zip Extra Field:")
+ .append(" Modify:[")
+ .append(getModifyFileTime())
+ .append("] ")
+ .append(" Access:[")
+ .append(getAccessFileTime())
+ .append("] ")
+ .append(" Create:[")
+ .append(getCreateFileTime())
+ .append("] ")
+ .toString();
+ // @formatter:on
}
}
(commons-compress) 06/06: Use StringUtils.repeat()
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 44706ad90c8f066b743a140b638624300aae311c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:47:25 2024 -0400
Use StringUtils.repeat()
---
src/test/java/org/apache/commons/compress/archivers/TarTest.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/test/java/org/apache/commons/compress/archivers/TarTest.java b/src/test/java/org/apache/commons/compress/archivers/TarTest.java
index 3bf2b1f31..e108e82e3 100644
--- a/src/test/java/org/apache/commons/compress/archivers/TarTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/TarTest.java
@@ -48,14 +48,12 @@ import org.apache.commons.compress.utils.ByteUtils;
import org.apache.commons.io.IOUtils;
import org.junit.jupiter.api.Test;
+import shaded.org.apache.commons.lang3.StringUtils;
+
public final class TarTest extends AbstractTest {
private String createLongName(final int nameLength) {
- final StringBuilder buffer = new StringBuilder();
- for (int i = 0; i < nameLength; i++) {
- buffer.append('a');
- }
- return buffer.toString();
+ return StringUtils.repeat('a', nameLength);
}
private byte[] createTarWithOneLongNameEntry(final String longName) throws IOException {
(commons-compress) 04/06: Fix Javadoc error
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit ee90be6e80d79b0504be89f2497ede472555f44d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:47:18 2024 -0400
Fix Javadoc error
---
.../commons/compress/compressors/gzip/GzipCompressorInputStream.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
index 555133f91..8a82e0737 100644
--- a/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
+++ b/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
@@ -58,7 +58,7 @@ import org.apache.commons.io.input.BoundedInputStream;
* <p>
* If you use the constructor {@code GzipCompressorInputStream(in, true)} then {@link #read} will return -1 only after
* the entire input stream has been exhausted; any bytes that follow an encoded GZIP member must constitute a new encoded
- * GZIP member, otherwise an {@link IOExcdetion} is thrown. The data read from a stream constructed this way will consist
+ * GZIP member, otherwise an {@link IOException} is thrown. The data read from a stream constructed this way will consist
* of the concatenated data of all of the encoded GZIP members in order.
* </p>
*
(commons-compress) 05/06: Use StringUtils.repeat()
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit 2f562a41f151c70dbf36259fd93d308fd5f87ba7
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:47:22 2024 -0400
Use StringUtils.repeat()
---
.../org/apache/commons/compress/archivers/tar/TarFileTest.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/test/java/org/apache/commons/compress/archivers/tar/TarFileTest.java b/src/test/java/org/apache/commons/compress/archivers/tar/TarFileTest.java
index 139f9e13a..2c6b4383e 100644
--- a/src/test/java/org/apache/commons/compress/archivers/tar/TarFileTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/tar/TarFileTest.java
@@ -43,6 +43,8 @@ import org.apache.commons.compress.AbstractTest;
import org.apache.commons.io.IOUtils;
import org.junit.jupiter.api.Test;
+import shaded.org.apache.commons.lang3.StringUtils;
+
public class TarFileTest extends AbstractTest {
private void datePriorToEpoch(final String archive) throws Exception {
@@ -143,11 +145,7 @@ public class TarFileTest extends AbstractTest {
root.mkdirs();
for (int i = 1; i < count; i++) {
// create empty dirs with incremental length
- final StringBuilder subDirBuilder = new StringBuilder();
- for (int j = 0; j < i; j++) {
- subDirBuilder.append("a");
- }
- final String subDir = subDirBuilder.toString();
+ final String subDir = StringUtils.repeat('a', i);
final File dir = new File(rootPath + "/" + dirDirectory, "/" + subDir);
dir.mkdir();
(commons-compress) 03/06: Use fluent style
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit dbca295f52f910e172712de1d6fffdb4372caec9
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Aug 1 07:39:01 2024 -0400
Use fluent style
---
.../commons/compress/harmony/unpack200/IcTuple.java | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/apache/commons/compress/harmony/unpack200/IcTuple.java b/src/main/java/org/apache/commons/compress/harmony/unpack200/IcTuple.java
index 438ae59c2..991b4257a 100644
--- a/src/main/java/org/apache/commons/compress/harmony/unpack200/IcTuple.java
+++ b/src/main/java/org/apache/commons/compress/harmony/unpack200/IcTuple.java
@@ -346,13 +346,15 @@ public class IcTuple {
@Override
public String toString() {
- final StringBuilder result = new StringBuilder();
- result.append("IcTuple ");
- result.append('(');
- result.append(simpleClassName());
- result.append(" in ");
- result.append(outerClassString());
- result.append(')');
- return result.toString();
+ // @formatter:off
+ return new StringBuilder()
+ .append("IcTuple ")
+ .append('(')
+ .append(simpleClassName())
+ .append(" in ")
+ .append(outerClassString())
+ .append(')')
+ .toString();
+ // @formatter:on
}
}