You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/08/26 12:50:50 UTC
[GitHub] couchdb-fauxton pull request: Continue secondary index
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/44
Continue secondary index
I've created a new branch from [#33](https://github.com/apache/couchdb-fauxton/pull/33). I will be continuing the work that @deathbearbrown and @jennschiffer started. I've squished the commits as much as possible. There was over 60 commits so I've done my best on that.
Below are the issues I am currently aware of on this branch. Any help to get these bugs squished would be greatly appreciated.
Pagination tab on /_all_dbs is not correct. It constantly shifts from left to right instead of being at the bottom.
- [ ] Couchdb’s login page needs some css fixing
- [ ] All api urls that I checked broken
- [ ] The “?” helper button for docs doesn’t open the docs on a new page
- [ ] The api url modal does not go away unless I click the “api url” text this is very frustrating for a user
- [ ] The query options url for views and all docs does not go away unless I click the “Query Options” text this is very frustrating for a user
- [ ] Query options on views doesn’t work. Clicking query does nothing
- [ ] On my 13” Mac if I select By Keys or Between Keys I cannot view the Query button its hidden and I cannot get to it.
- [ ] If I click new secondary view from the modal over a design doc. The design doc is not preselected in the view editor
- [ ] Creating a new view saves but an error in the console occurs so we don’t get a list of docs for that view
- [ ] After save it also then changes the design doc in the drop down for this view
- [ ] Deleting a doc give the message “undefined is deleted”
- [ ] On all docs if I select include_docs and click query, then close the query options and open it again. The “include_docs” is not selected even though all the docs visible include the full docs
- [ ] When clicking the select buttons the new header with the trash button is not done correctly. The buttons look very wrong.
- [ ] The cursor is incorrect when I hover over the select button
- [ ] Click design docs is broken it shows all docs - This is fixed in my other branch so maybe not an issue.
- [ ] If I try and save a view twice it fails from a conflict issue. - we have had this issue before and I think we have resolved it.
- [ ] Login view and access denied page is needs slightly better alignment.
- [ ] Design Doc Metadata is aligned but I don’t think those colours are correct for the background.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton continue-secondary-index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 113615ff1ba61a024f9c3e6018a32deadcc5424a
Author: deathbearbrown <de...@gmail.com>
Date: 2014-08-02T15:24:51Z
buncha editor stuff
making the preview page look less butts.
Styling the view form
documents
This stuff can't be tables. Boo.
less for indexes
resize stuff
And more refactor stuff
View editor updates,
Splitting out less files
An absolute abortion happening in the resizeColumns file
style form fields and tab buttons
move around query options, init style
routes stuff
removed the breadcrumbs POC
Step one in cleaning up that gnarly save on indexes
Always show editor
fixing layout
Adding Views, testing header stuff, fixing layout issues
Add all the indexes to the sidebar
Fix sidebar to work with different indexes
Added the apache license
changed a comment ffs.
Ripping out views into it's own addon
Setting Up Indexes addon
fix new indexes
Move Fauxton's apibar and breadcrumbs out into components
design doc ui
An insane amount of header stuff
Ripping out views into it's own addon
Add all the indexes to the sidebar
Fix sidebar to work with different indexes
Added the apache license
changed a comment ffs.
Adding Views, testing header stuff, fixing layout issues
move around query options, init style
style form fields and tab buttons
button and search box moved to header on all docs
style query options now it is inside header
move old alldocs stuff to advancedopts
refactor query options button to header
have options properly toggle, style button
style keys well, get new checkbox inputs working
styling header and query options, add cancel button
cancel button functionality, styling
style search box
Fixes for the header
Left header is now a reusable component
Header stuff
placeholder graphic
Messed up folders
Fix design doc selector
Changes header (not styled)
Make pagination fixed to the bottom and update files with apache license
select toggle
expand and collapse
commit fe455df076edf1b67e27ffe079c3f43883e19b3c
Author: deathbearbrown <de...@gmail.com>
Date: 2014-08-06T21:06:55Z
Secondary Index work:
Select all got borked
I'm dumb and when I rebased I removed this import
select menu stuff
move pagination stuff to footer
fix events on select doc header
Use events for advanced options
Adding the dropdown menu in all_docs
Hooked up Delete DB & event handling in menuDropDown
Trigger event to go back to prev header on Bulk Delete
commit fce5dfe15b0a29217193b1c45263260ab54bf75e
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-08-07T20:36:58Z
Secondary Index work:
style buttons to right header
fix tray styling from button work
hide other trays when opening another tray
commit e196a738646e9e8f575a16e2720cafe0d5f84b95
Author: deathbearbrown <de...@gmail.com>
Date: 2014-08-11T19:18:50Z
Secondary Index work:
fix semi colon and alldocs select in header
Moved the Header styles into the global header styles
Changes header, updating the view headers and adding the link icons
Hook up delete dropdown on views
Pagination footer
Colors!!!!
Working on alert styling
footer css updates and alert styling
Design doc selector fix
pagination fix
Fixed pagination on indexes
adding back some route events
comment out remove crumbs
remove useless forcerenders for the breadcrumbs
Fix styling the select toggle show
Change the all docs select header to be it's own view
Fix for the header on view save
commit 8129168ee11152eea45d9ac7e12aa3e78eca1a4f
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-08-13T19:16:45Z
Secondary index work:
use Events to close trays
refactor css for header trays
style api bar button on fixed header
fix api bar help icon
commit 16049ba5b4c148577811d2bf191a6f765d9ac205
Author: deathbearbrown <de...@gmail.com>
Date: 2014-08-14T18:51:55Z
Secondary Index work:
Header stuff for all docs
Fixed the resizeColumns code that was the worst
fixing some padding issues in other addons
Commenting out the POC and placeholder stuff
css cleanup
All DBs header update
Fix replication links from all dbs page and header
Fixing rebase issue with the docs
Api button alignment on non all DBs pages
Config add new button was hidden
Verify install too cramped
search icon alignment
Fauxton events in one line
removed Preview from the indexes since it's borked
Fixed on On Save and Build Index
Add Unbinds to the global events on cleanup. This will fix that delete triggering the popup a bunch of times issue
padding to design doc meta data
Removed comment. Fixed case on event
error and comment clean up. All errors will be shown in the global section
remove index-components placeholder file
Removed Pouch for now
comment language update
remove unused eventer
removed table view from dropdown
removed that one index spec because it seemed like a place holder? Fixed the paginate Spec to include the correct resources
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Continue secondary index
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/44#issuecomment-54142354
I'm abandoning this and just moving in the work bit by bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Continue secondary index
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/44#issuecomment-53991688
Hi garren, I could not get this running so I opened a PR against the original branch.
https://github.com/apache/couchdb-fauxton/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Continue secondary index
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Continue secondary index
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/44#issuecomment-53992856
Hi Robert, I've abandoned this branch. Any PR must be done against master.
On Sunday, August 31, 2014, Robert Kowalski <no...@github.com>
wrote:
> Hi garren, I could not get this running so I opened a PR against the
> original branch.
>
> #48 <https://github.com/apache/couchdb-fauxton/pull/48>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-fauxton/pull/44#issuecomment-53991688>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---