You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "abhi-ksolves (via GitHub)" <gi...@apache.org> on 2025/07/30 07:46:35 UTC
[PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
abhi-ksolves opened a new pull request, #20260:
URL: https://github.com/apache/kafka/pull/20260
As per the [discussion](https://issues.apache.org/jira/browse/KAFKA-16801#:~:text=is%20what%20we%20did%20recently%20(KAFKA%2D14759)%20with%20connect%3Atest%2Dplugins%2C%20but%20is%20the%20most%20disruptive.%20If%20these%20are%20only%20used%20in%20the%20system%20tests%20(no%20outside%20dependencies)%20then%20I%20think%20this%20would%20probably%20be%20the%20best%20option.), the approach 4 movement from the test directories to main is implemented.
Ticket Link :- https://issues.apache.org/jira/browse/KAFKA-16801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20260:
URL: https://github.com/apache/kafka/pull/20260#discussion_r2305508706
##########
streams/upgrade-system-tests-0110/src/main/java/org/apache/kafka/streams/StreamsUpgradeTest.java:
##########
@@ -43,7 +41,7 @@ public static void main(final String[] args) throws Exception {
System.out.println("props=" + streamsProperties);
final KStreamBuilder builder = new KStreamBuilder();
- final KStream dataStream = builder.stream("data");
+ final KStream<String, String> dataStream = builder.stream("data");
Review Comment:
Can we maybe do this cleanup in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #20260:
URL: https://github.com/apache/kafka/pull/20260#issuecomment-3235275904
Seems this issue is getting resolved via https://github.com/apache/kafka/pull/19513/commits/6295c8a98262624e5415f581e12530aa602ab95b
Should we close this PR, or wait until#19513 got merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20260:
URL: https://github.com/apache/kafka/pull/20260#issuecomment-3162317516
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 closed pull request #20260: Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests
URL: https://github.com/apache/kafka/pull/20260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #20260:
URL: https://github.com/apache/kafka/pull/20260#discussion_r2305521015
##########
streams/upgrade-system-tests-0110/src/main/java/org/apache/kafka/streams/StreamsUpgradeTest.java:
##########
@@ -14,11 +14,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.kafka.streams.tests;
+package org.apache.kafka.streams;
Review Comment:
Seems we need to change the package name, to avoid conflicts with the "main" `StreamsUpgradeTest.java` ?
Could this cause issue when running the corresponding upgrade system test? We hardcode the same name across all version (including `trunk`) https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/streams.py#L601
This will all be quite tricky to clean up, as older jar we currently load, will provide the old name...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20260:
URL: https://github.com/apache/kafka/pull/20260#issuecomment-3376231819
```
chia7712@fedora:~/project/kafka$ ./gradlew cleanTest streams:upgrade-system-tests-37:test
> Configure project :
Starting build with version 4.2.0-SNAPSHOT (commit id c6bbbbe2) using Gradle 9.1.0, Java 21 and Scala 2.13.16
Build properties: ignoreFailures=false, maxParallelForks=24, maxScalacThreads=8, maxTestRetries=0
[Incubating] Problems report is available at: file:///home/chia7712/project/kafka/build/reports/problems/problems-report.html
Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/9.1.0/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 10s
71 actionable tasks: 6 executed, 65 up-to-date
Consider enabling configuration cache to speed up this build: https://docs.gradle.org/9.1.0/userguide/configuration_cache_enabling.html
```
`streams:upgrade-system-tests-37:test` works well after merging #19513, so I'm going to close this PR. Please feel free to reopen it if I misunderstand anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org