You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by David Jencks <da...@yahoo.com> on 2006/09/12 17:59:31 UTC
RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
I'd like to thank the PMC members who promptly reviewed my jta 1.1
and jndi refactoring patches and point them to an at least equally
deserving patch that has been quietly mouldering for lack of attention
http://issues.apache.org/jira/browse/GERONIMO-2163
Aside from
- Integrating WADI in an architecturally appropriate way (finally!)
- Providing a clustering api as a basis for discussion and further
development
this also now includes a big improvement to the
NamespaceDrivenBuilder interface that lets these builders add stuff
to the environment. We should be able to leverage this to e.g. only
include axis when you are actually using a web service and/or switch
webservices implementations.
thanks
david jencks
Re: RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
Posted by Bill Dudney <bd...@mac.com>.
Hi Gianny,
I applied the patch and got a few simple to fix hunks failing. Got
them fixed and it built until the failure to find the wadi-group
artifact. Any chance that could get uploaded so I can be lazy and not
build it myself?
If I understand things correctly geronimo-clustering is an
alternative to the geronimo-session module we had/have in the 1.2-
dead branch. Am I correct? Just trying to make sure I understand
things correctly.
And one last thing, I to would like to see some more docs at least in
the geronimo-clustering module.
Thanks!
-bd-
On Sep 13, 2006, at 9:34 AM, Gianny Damour wrote:
> Many thanks David for this wake-up call :)
>
> I do agree: the NamespaceDrivenBuilder change is a great
> improvement. If I am entitled to vote for this patch, even if I am
> one of the reporters, then we now have 3 +1. Having said that, I
> would appreciate if Greg could have a quick scan prior to commit.
>
> Thanks,
> Gianny
>
>
> On 13/09/2006, at 1:59 AM, David Jencks wrote:
>
>> I'd like to thank the PMC members who promptly reviewed my jta 1.1
>> and jndi refactoring patches and point them to an at least equally
>> deserving patch that has been quietly mouldering for lack of
>> attention
>>
>> http://issues.apache.org/jira/browse/GERONIMO-2163
>>
>> Aside from
>>
>> - Integrating WADI in an architecturally appropriate way (finally!)
>> - Providing a clustering api as a basis for discussion and further
>> development
>>
>> this also now includes a big improvement to the
>> NamespaceDrivenBuilder interface that lets these builders add
>> stuff to the environment. We should be able to leverage this to
>> e.g. only include axis when you are actually using a web service
>> and/or switch webservices implementations.
>>
>> thanks
>> david jencks
>>
>
Re: RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
Posted by Kevan Miller <ke...@gmail.com>.
On Sep 13, 2006, at 11:34 AM, Gianny Damour wrote:
> Many thanks David for this wake-up call :)
>
> I do agree: the NamespaceDrivenBuilder change is a great
> improvement. If I am entitled to vote for this patch, even if I am
> one of the reporters, then we now have 3 +1. Having said that, I
> would appreciate if Greg could have a quick scan prior to commit.
Hey Gianny,
I did start to look at your patch last night. I have a bit more work
to do (review the api, apply and build...)
I have two initial comments:
1) I don't see any unit tests.
2) I see very few code comments. At a minimum, I would expect a
clustering api to have javadoc-style comments. I also would expect
new code to be well commented. IMO, we, as a project, are *abysmal*
at this. This is about to become (is?) a hot button for me (sorry to
start out with you... ;-). I hope to work on a note on that topic
sometime today...
Thoughts on 1) and 2)?
--kevan
Re: RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
Posted by Gianny Damour <gi...@optusnet.com.au>.
Many thanks David for this wake-up call :)
I do agree: the NamespaceDrivenBuilder change is a great improvement.
If I am entitled to vote for this patch, even if I am one of the
reporters, then we now have 3 +1. Having said that, I would
appreciate if Greg could have a quick scan prior to commit.
Thanks,
Gianny
On 13/09/2006, at 1:59 AM, David Jencks wrote:
> I'd like to thank the PMC members who promptly reviewed my jta 1.1
> and jndi refactoring patches and point them to an at least equally
> deserving patch that has been quietly mouldering for lack of attention
>
> http://issues.apache.org/jira/browse/GERONIMO-2163
>
> Aside from
>
> - Integrating WADI in an architecturally appropriate way (finally!)
> - Providing a clustering api as a basis for discussion and further
> development
>
> this also now includes a big improvement to the
> NamespaceDrivenBuilder interface that lets these builders add stuff
> to the environment. We should be able to leverage this to e.g.
> only include axis when you are actually using a web service and/or
> switch webservices implementations.
>
> thanks
> david jencks
>
Re: RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
Posted by David Jencks <da...@yahoo.com>.
Apply only http://issues.apache.org/jira/secure/attachment/12340048/
GERONIMO-2163-v6c.patch
There are some instructions on setting up a testbed that require some
other files. Personally I wasn't able to follow all of them but I
think this patch is worth applying anyway.
The clustering contract is in the new module geronimo-clustering and
to the extent I understand (probably small) it it looks pretty self-
explanatory to me.
New modules:
geronimo-clustering: interfaces for proposed clustering contract
geronimo-clustering-wadi: implementation of this contract for WADI
geronimo-clustering-builder-wadi: a NamespaceDrivenBuilder to set the
aforementioned stuff up
Modified modules:
geronimo-deployment: improvements to NamespaceDrivenBuilder (requires
changes in all the NDBs, geronimo-service-builder and geronimo-
security-builder)
geronimo-jetty: changes to get jetty to talk to the clustering
interfaces as appropriate
geronimo-jetty-builder: changes to allow the wadi clustering builder
to be plugged in.
New Configs:
jetty-clustering-wadi: "static" support for wadi, sort of like the
jetty container.
jetty-clustering-builder-wadi: the jetty-wadi-builder
Modified Configs:
jetty: use the clustering interface
jetty-deployer: add the clustering builder if present
Modified assemblies:
geronimo-jetty-j2ee: include the new configs
Hope this helps
thanks
david jencks
On Sep 12, 2006, at 12:03 PM, Jeff Genender wrote:
> Wow...that's a *lot* of patches. Before applying and giving a +1, can
> we just get a small synopsis here on the clustering contract and
> bullet
> point of the contents. Also...which patch to apply? ;-)
>
> Jeff
>
> David Jencks wrote:
>> I'd like to thank the PMC members who promptly reviewed my jta 1.1
>> and
>> jndi refactoring patches and point them to an at least equally
>> deserving
>> patch that has been quietly mouldering for lack of attention
>>
>> http://issues.apache.org/jira/browse/GERONIMO-2163
>>
>> Aside from
>>
>> - Integrating WADI in an architecturally appropriate way (finally!)
>> - Providing a clustering api as a basis for discussion and further
>> development
>>
>> this also now includes a big improvement to the
>> NamespaceDrivenBuilder
>> interface that lets these builders add stuff to the environment. We
>> should be able to leverage this to e.g. only include axis when you
>> are
>> actually using a web service and/or switch webservices
>> implementations.
>>
>> thanks
>> david jencks
Re: RTC Yoo-Hoo Wake Up Please and Review the Wadi Integration Patch
Posted by Jeff Genender <jg...@apache.org>.
Wow...that's a *lot* of patches. Before applying and giving a +1, can
we just get a small synopsis here on the clustering contract and bullet
point of the contents. Also...which patch to apply? ;-)
Jeff
David Jencks wrote:
> I'd like to thank the PMC members who promptly reviewed my jta 1.1 and
> jndi refactoring patches and point them to an at least equally deserving
> patch that has been quietly mouldering for lack of attention
>
> http://issues.apache.org/jira/browse/GERONIMO-2163
>
> Aside from
>
> - Integrating WADI in an architecturally appropriate way (finally!)
> - Providing a clustering api as a basis for discussion and further
> development
>
> this also now includes a big improvement to the NamespaceDrivenBuilder
> interface that lets these builders add stuff to the environment. We
> should be able to leverage this to e.g. only include axis when you are
> actually using a web service and/or switch webservices implementations.
>
> thanks
> david jencks