You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/04/10 08:16:52 UTC
[GitHub] [kyuubi] turboFei opened a new pull request, #4680: Fast return batch info when post batches
turboFei opened a new pull request, #4680:
URL: https://github.com/apache/kyuubi/pull/4680
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501708234
cc @zwangsheng as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501579640
> it is impossible to get the application status in most cases.
What's the current result in your production case? UNKNOWN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501588975
<img width="1413" alt="image" src="https://user-images.githubusercontent.com/6757692/230871714-4ec56e51-e49d-4ce0-a734-baaec71c5eec.png">
It is none, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1502562346
My idea is, revert https://github.com/apache/kyuubi/pull/3922, and always propagate app status to the client.
During submitting phase, ApplicationManager returns UNKNOWN instead of NOT_FOUND when elapsed time < `kyuubi.engine.submit.timeout`, same as we did in https://github.com/apache/kyuubi/pull/4469 for K8s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501604251
We have UNKNOWN state, why should return null/None instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501605613
I think we need to re-evaluate https://github.com/apache/kyuubi/pull/3922, it's similar to https://github.com/apache/kyuubi/pull/4469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501562931
How can we return app id if we do not get application status when creating batch ? Do you mean we do not need to return app related info when creating batch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501566065
cc @pan3793 not sure if it breaks your customer ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501565312
> How can we return app id if we do not get application status when creating batch ? Do you mean we do not need to return app related info when creating batch ?
Yes, the key information is batchId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1501566996
I think that usually the response for create batch request should be returned in milliseconds.
So, it is impossible to get the application status in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #4680: Skip to get the batch application status when creating batch
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #4680:
URL: https://github.com/apache/kyuubi/pull/4680#issuecomment-1502605222
I'm + 1 for get `Unknown` state, after spark submit but we not find application from yarn cluster.
And using timeout to check whether submit success or not.
Unknown sounds more reasonable, when we submit but can fount app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #4680: Skip to get the batch application status when creating batch
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #4680: Skip to get the batch application status when creating batch
URL: https://github.com/apache/kyuubi/pull/4680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org