You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/21 17:10:45 UTC

[GitHub] [arrow] projjal commented on pull request #7504: ARROW-9193: [C++] Add method to parse date from null-terminated string

projjal commented on pull request #7504:
URL: https://github.com/apache/arrow/pull/7504#issuecomment-647155468


   Hi @wesm can you take a look at this. It seems that the ParseTimestampStrptime function was recently changed from taking c-style null terminated string input to c++ style. If the input string was already null terminated then this method significantly slows down due to extra allocation and copies from constructor and c_str(). From the benchmark test that I have added it seems that it gets about 2-2.5x slower. Would it make sense to add another method that explicitly takes null-terminated string as input to avoid these copies.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org