You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/10/18 23:01:38 UTC
[GitHub] [mynewt-newtmgr] ccollins476ad opened a new pull request #147:
nmxact: Don't skip seq numbers in `image upload`
ccollins476ad opened a new pull request #147: nmxact: Don't skip seq numbers in `image upload`
URL: https://github.com/apache/mynewt-newtmgr/pull/147
nmxact generates several image upload requests for each one that it actually sends. It does this to determine the ideal chunk size.
Each of these requests was consuming a sequence number. As a result, the sequence number would increase by three for each request that was actually transmitted.
This PR changes the image upload command such that the sequence number is only increased when a request is actually sent.
This PR also removes the "Serialized OMP" debug log message. This message got logged immediately before the request got transmitted. The result was two nearly identical large log messages (both contain the full payload of the request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services