You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/22 07:05:32 UTC

[GitHub] [pulsar] equanz opened a new pull request #6794: [Issue 6793][broker] Add config of maxNumPartitionsPerPartitionedTopic

equanz opened a new pull request #6794:
URL: https://github.com/apache/pulsar/pull/6794


   Fixes #6793
   
   ### Motivation
   Now broker, can't set max number of partitions per partitioned topic. So we can't prevent to create partitioned topic by many partitions from server side.
   In this PR, introduce limit of max partitions to broker and to be able to control it.
   
   ### Modifications
   Add `maxNumPartitionsPerPartitionedTopic` config to broker and compare with numPartitions at create or update partitioned topic.
   If the config is set to `0`(is default), then disable the check.
   
   ### Verifying this change
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
     - Unit tests for maxNumPartitionsPerPartitionedTopic config
   
   ### Does this pull request potentially affect one of the following parts:
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (yes)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on issue #6794: [Issue 6793][broker] Add config of maxNumPartitionsPerPartitionedTopic

Posted by GitBox <gi...@apache.org>.
equanz commented on issue #6794:
URL: https://github.com/apache/pulsar/pull/6794#issuecomment-618124082


   @codelipenghui 
   Thank you for your review!
   
   > Could you please help add some checks for partitioned topic auto-creation?
   
   Is this here or should I add some unit tests?
   
   https://github.com/apache/pulsar/blob/36d4f36922afd21b8f2454b6f343f78804ea20e5/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1896-L1900


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on issue #6794: [Issue 6793][broker] Add config of maxNumPartitionsPerPartitionedTopic

Posted by GitBox <gi...@apache.org>.
equanz commented on issue #6794:
URL: https://github.com/apache/pulsar/pull/6794#issuecomment-617606657


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #6794: [Issue 6793][broker] Add config of maxNumPartitionsPerPartitionedTopic

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #6794:
URL: https://github.com/apache/pulsar/pull/6794#issuecomment-619361227


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nkurihar commented on pull request #6794: [Issue 6793][broker] Add config of maxNumPartitionsPerPartitionedTopic

Posted by GitBox <gi...@apache.org>.
nkurihar commented on pull request #6794:
URL: https://github.com/apache/pulsar/pull/6794#issuecomment-620306706


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org