[GitHub] [incubator-doris] morningman commented on a change in pull request #5617: [Bug] Fix alter table failed when none of new load jobs succeed on alter replica

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5617:
URL: https://github.com/apache/incubator-doris/pull/5617#discussion_r612585005



##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -536,6 +537,7 @@ private void cancelInternal() {
                         partition.deleteRollupIndex(rollupIndexId);
                     }
                     tbl.deleteIndexInfo(rollupIndexName);
+                    tbl.setState(OlapTableState.NORMAL);

Review comment:
       Same as above

##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -494,6 +494,7 @@ private void onFinished(OlapTable tbl) {
             partition.visualiseShadowIndex(rollupIndexId, false);
         }
         tbl.rebuildFullSchema();
+        tbl.setState(OlapTableState.NORMAL);

Review comment:
       We can to batch rollup jobs, and I think the table's state should be set to NORMAL after all jobs are done,
   which is in MaterializedViewHandler.onJobDone()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org