You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/22 13:55:47 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new issue #845: Can we change armv8-m porting to apache license?
xiaoxiang781216 opened a new issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845
@patacongo should we keep BSD license in the intial commit and wait you modify to apache license later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617885141
As has been mentioned in other threads, we cannot do this just based on the
copyright name. We also need to look at the authorship of the files. This
needs to be done in a methodical way, there is some discussion on the wiki
about going forward with this.
Merging changes without doing this correctly makes it a lot harder to go
back and verify.
--Brennan
On Wed, Apr 22, 2020, 9:09 AM Xiang Xiao <no...@github.com> wrote:
> Yes, you have my permission to modify the licenses to Apache 2.0 provided
> that I am the sole copyright holder and the sole author. Other cases are
> more complex.
>
> Perhaps we should resolve all license headers in armv7-m first?
>
> Good ideal, we can resolve as much as possible first.
>
> Other than me and Pinecone as claimed copyright holders, these files look
> problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c,
> up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
>
> Pinecone is fully controlled by Xiaomi, so I think it isn't a big issue.
> How to handle the rest file, keep the copright as armv7-m?
>
> We need advice from a mentor.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617874941>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABKJPINHEHNSMR4P2CEXT3RN4JB7ANCNFSM4MOGAFSA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618026733
There are a handful of other problem files. I left them as they are for ARMv7-M. The question is, "What do we do for those when we leverage them to ARMv8-M?" There are three ARM header files, one PX4 file, and three or four more with either other people's persoanan name in the Copyright. Or they made trivial changes to my file and then decided they deserve a Copyright too. I always thought that was bad taste but that is the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618021735
> Do we have a SGA for Pinecone. I think Justin has warned us about this before, that in this case we need the company approval to change the licensing of the file not just the author.
The is a different issue. We did not change any Pinecone headers and do not plan to.
That is for the ARMv7-M architecture. Xiang is implementing the ARMv8-M architecture which will have all new files. If Xiang wrote those files and put the Pinecone license on them. If Xiang generates new files they will have Apache licensing.
So this is a grey area. But rest assured, not existing Pinecone file will have its header changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617984186
>
>
> Yes, that is why is better that @patacongo clean up armv7-m arch manually and then armv8-m just need follow the result. I think no other people better than him to decide the right copyright license.
@xiaoxiang781216 Done. Please review and merge PR #848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618014818
@xiaoxiang781216 There are a few Pinecone files that I could not change. You wrote those files. When you create new versions for armv8-m, you should be able to use the Apache 2.0 on the new files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617811436
Other than me and Pinecone as claimed copyright holders, these files look problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c, up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
We need advice from a mentor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618025321
Awesome! This all sounds good to me, just wanted to make sure we are on the same page to save trouble down the road.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617797373
I am not the expert here. But I don't think that anything can come into the repositories that does not have an Apache 2.0 licence. That is the rule that we have been enforcing.
If it is not Apache code, then it is third party code and I think we would need an SGA or some such thing. Again, i am not the expert. You should ask Justin, not me.
I would not personally merge any files that have BSD licenses or any Copyrights on them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618390735
Ok, we will refine our patch basse on @patacongo copyright change, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618024074
I am the only party who has submitted the SGA so only my files can have the header changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617798725
I think that all of the answers are here: https://www.apache.org/legal/resolved.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618026733
There are a handful of other problem files. I left them as they are for ARMv7-M. The question is, "What do we do for those when we leverage them to ARMv8-M?" There are three ARM header files, one PX4 file, and three or four more with either other people's persoanan name in the Copyright. Or then made trivial changes to my file and then decided they deserve a Copyright too. I always thought that was bad taste but that is the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617811436
Other than me and Pinecone as claimed copyright holders, these files look problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c, up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617887177
Yes, that is why is better that @patacongo clean up armv7-m arch manually and then armv8-m just need follow the result. I think no other people better than him to decide the right copyright license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617803135
All most code under armv7-m come from you. It isn't a big issue If you give us the permission to modify the license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618019497
Do we have a SGA for Pinecone. I think Justin has warned us about this before, that in this case we need the company approval to change the licensing of the file not just the author.
I'm all for getting this done I just don't want to have questions later about if the conversion was done correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617874941
> Yes, you have my permission to modify the licenses to Apache 2.0 provided that I am the sole copyright holder and the sole author. Other cases are more complex.
>
> Perhaps we should resolve all license headers in armv7-m first?
Good ideal, we can resolve as much as possible first.
> Other than me and Pinecone as claimed copyright holders, these files look problematic: dwt.h, etm.h, fpb.h, itm.h, itm_syslog.h, tpi.h, up_cache.c, up_itm.c, up_itm_syslog.c, up_stackcheck.c, and up_vectors.S
>
Pinecone is fully controlled by Xiaomi, so I think it isn't a big issue. How to handle the rest file, keep the copright as armv7-m?
> We need advice from a mentor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-618024074
I am the only party who has submitted the SGA so only my files can have the header changed.
But new files should all be apache 2.0 unless there is some other reason that requires a different license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #845: Can we change armv8-m porting to apache license?
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #845:
URL: https://github.com/apache/incubator-nuttx/issues/845#issuecomment-617807799
Yes, you have my permission to modify the licenses to Apache 2.0 provided that I am the sole copyright holder and the sole author. Other cases are more complex.
Perhaps we should resolve all license headers in armv7-m first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org