You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/07/14 09:56:07 UTC

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16195


Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................

Bump up CDP_BUILD_NUMBER to 4493826

This change bumps up the CDP_BUILD_NUMBER to 4493826. This is needed
to fix a failing test.

Hive started to assign bucket ids to files differently. Because of
that I had to modify the test_full_acid_rowid test that had an
assumption about how bucket ids are assigned to files.

If you have problems restarting the Hive Metastore, try the following:

  buildall.sh <your usual flags> -upgrade_metastore_db

If you have problems restarting Kudu, try the following:

  Unset LD_LIBRARY_PATH in your shell, and stop setting it in
  impala-config-local.sh

Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
---
M bin/impala-config.sh
M fe/pom.xml
M testdata/workloads/functional-query/queries/QueryTest/full-acid-rowid.test
3 files changed, 25 insertions(+), 17 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/16195/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6130/


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 20:02:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 2: Code-Review+2

Thanks for fixing this


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 16:00:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16195

to look at the new patch set (#3).

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................

Bump up CDP_BUILD_NUMBER to 4493826

This change bumps up the CDP_BUILD_NUMBER to 4493826. This is needed
to fix a failing test.

Hive started to assign bucket ids to files differently. Because of
that I had to modify the test_full_acid_rowid test that had an
assumption about how bucket ids are assigned to files.

If you have problems restarting the Hive Metastore, try the following:

  buildall.sh <your usual flags> -upgrade_metastore_db

If you have problems restarting Kudu, try the following:

  Unset LD_LIBRARY_PATH in your shell, and stop setting it in
  impala-config-local.sh

Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
---
M bin/impala-config.sh
M fe/pom.xml
M testdata/workloads/functional-query/queries/QueryTest/full-acid-rowid.test
3 files changed, 30 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/16195/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jul 2020 19:14:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6130/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 10:03:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jul 2020 15:16:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6590/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 12:06:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6607/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jul 2020 10:29:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6129/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 10:02:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6591/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 12:52:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................

Bump up CDP_BUILD_NUMBER to 4493826

This change bumps up the CDP_BUILD_NUMBER to 4493826. This is needed
to fix a failing test.

Hive started to assign bucket ids to files differently. Because of
that I had to modify the test_full_acid_rowid test that had an
assumption about how bucket ids are assigned to files.

If you have problems restarting the Hive Metastore, try the following:

  buildall.sh <your usual flags> -upgrade_metastore_db

If you have problems restarting Kudu, try the following:

  Unset LD_LIBRARY_PATH in your shell, and stop setting it in
  impala-config-local.sh

Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Reviewed-on: http://gerrit.cloudera.org:8080/16195
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M testdata/workloads/functional-query/queries/QueryTest/full-acid-rowid.test
3 files changed, 30 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 )

Change subject: Bump up CDP_BUILD_NUMBER to 4493826
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6135/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16195
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4635feef146c945624135e0715495bb01ea4699
Gerrit-Change-Number: 16195
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jul 2020 10:06:12 +0000
Gerrit-HasComments: No