You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2018/08/23 18:35:08 UTC
[GitHub] nifi pull request #2961: NIFI-5479: Upgrade Jetty
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2961
NIFI-5479: Upgrade Jetty
Upgrading Jetty. Including a commit that @joewitt had provided in PR #2933. I have provided an additional commit that addresses a behavioral change in Jetty's SslContextFactory. I have verified various NiFi deployments including (un)secured standalone and clustered instances using both certificate based authentication and our JWT authentication using OpenID Connect.
Once this PR is closed, we can also close #2933.
@markap14 Can you help verify some of our processors that leverage the bundled Jetty server?
@ijokarumawak Can you help verify our web socket processors?
Would also appreciate anyone else willing to deploy this proposed change to ensure there aren't any other regressions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-5479
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2961
----
commit 0364cf584b55a617c6eded719f0bc5a8baf91c99
Author: joewitt <jo...@...>
Date: 2018-08-02T20:29:23Z
NIFI-5479 Upgraded Jetty. Moved where we unpack bundled deps to so we can avoid a new jetty bug with META-INF loading logic. WIP for testing/eval. Not ready for merge
commit 39e537c8c172e0675eb1e3a9918c3329aea4d9cd
Author: Matt Gilman <ma...@...>
Date: 2018-08-23T18:21:28Z
NIFI-5479:
- Using the SUN provider when the keystore type is JKS.
----
---
[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2961
Of note, I was also able to verify PostHTTP, ListenHTTP, and HandleHttpRequest/Response both using SSL Context and without SSLContext.
---
[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2961
@mcgilman I was able to verify that the HandleHttpRequest and HandleHttpResponse processors still work - and in fact work better! This appears to have addressed NIFI-5522.
---
[GitHub] nifi pull request #2961: NIFI-5479: Upgrade Jetty
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2961
---
[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2961
@mcgilman I've confirmed that NiFi Websocket component uses the updated Jetty version and works without issue. I'm a +1 on this, too. Thanks for this fix, merging!
---
[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2961
@ijokarumawak as far as I'm concerned, I'm a +1 on this. If you're also happy with it, please feel free to go ahead and merge to master & mark as resolved. Thanks! And thanks @mcgilman for the PR - this is very timely!
---