You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ma...@apache.org on 2008/06/12 20:45:10 UTC

svn commit: r667195 - /myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java

Author: matzew
Date: Thu Jun 12 11:45:10 2008
New Revision: 667195

URL: http://svn.apache.org/viewvc?rev=667195&view=rev
Log:
TRINIDAD-1117 - Allow String converters

Thanks for Martin Koci for his patch.

Modified:
    myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java

Modified: myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java?rev=667195&r1=667194&r2=667195&view=diff
==============================================================================
--- myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java (original)
+++ myfaces/trinidad/trunk_1.2.x/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ConverterUtils.java Thu Jun 12 11:45:10 2008
@@ -152,11 +152,13 @@
     FacesContext context,
     Class<?>     converterType)
   {
-    // Don't bother for Strings and Objects;  note that the 1.1_01 RI
+    // Don't bother for Objects;  note that the 1.1_01 RI
     // returns null, but the spec requires a FacesException, and MyFaces
     // correctly implements that.
+	  
+	// https://issues.apache.org/jira/browse/TRINIDAD-1117
+	// Note - JSF 1.2 allows converter for String: https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=131   
     if (converterType == null ||
-        converterType == String.class ||
         converterType == Object.class)
     {
       return null;