You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2010/12/20 17:59:00 UTC
[jira] Created: (WICKET-3275) Log a warn or throw an exception when
an AjaxFormComponentUpdatingBehavior is added to an choice component
Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
----------------------------------------------------------------------------------------------------------
Key: WICKET-3275
URL: https://issues.apache.org/jira/browse/WICKET-3275
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M3, 1.4.14
Reporter: Pedro Santos
Priority: Trivial
I was thinking about warn on console:
String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos resolved WICKET-3275.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.16
AFCCUB has the same test already, I just refactor the code
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos resolved WICKET-3275.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
1.4.16
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974702#action_12974702 ]
Martin Grigorov commented on WICKET-3275:
-----------------------------------------
What about adding the same check, but negated, in AjaxFormChoiceComponentUpdatingBehavior ?
I don't remember users complaining about such error in the lists but it'd be the same result if the user adds AFCCUB to TextField for example.
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977357#action_12977357 ]
Hudson commented on WICKET-3275:
--------------------------------
Integrated in Apache Wicket 1.4.x #367 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/367/])
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973287#action_12973287 ]
Hudson commented on WICKET-3275:
--------------------------------
Integrated in Apache Wicket 1.4.x #346 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/346/])
Log a warn when an AjaxFormComponentUpdatingBehavior is added to an choice component
Issue: WICKET-3275
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Priority: Trivial
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos reopened WICKET-3275:
----------------------------------
Good idea, I think it will be helpful to users, reopening
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973255#action_12973255 ]
Martin Grigorov commented on WICKET-3275:
-----------------------------------------
Repeaters log warning only in DEV mode when the child id is not safe (digit only).
I find it suitable for this case too.
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Priority: Trivial
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3275) Log a warn or throw an exception
when an AjaxFormComponentUpdatingBehavior is added to an choice component
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos reassigned WICKET-3275:
------------------------------------
Assignee: Pedro Santos
> Log a warn or throw an exception when an AjaxFormComponentUpdatingBehavior is added to an choice component
> ----------------------------------------------------------------------------------------------------------
>
> Key: WICKET-3275
> URL: https://issues.apache.org/jira/browse/WICKET-3275
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.14, 1.5-M3
> Reporter: Pedro Santos
> Assignee: Pedro Santos
> Priority: Trivial
> Fix For: 1.4.16, 1.5-M4
>
>
> I was thinking about warn on console:
> String.format("AjaxFormComponentUpdatingBehavior is not suposed to be add in the form component %s. AjaxFormChoiceComponentUpdatingBehavior is meant for choices/groups that are not one component in the html but many", getComponent().getPageRelativePath())
> at AjaxFormComponentUpdatingBehavior#bind when we detect that the component is an instance of: RadioChoice, CheckBoxMultipleChoice, RadioGroup, CheckGroup
> Just don't know if it is better throw an exception instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.