You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/07 09:56:48 UTC
[GitHub] [hbase-filesystem] wchevreuil opened a new pull request #16: HBASE-24989 [HBOSS] Some code cleanup
wchevreuil opened a new pull request #16:
URL: https://github.com/apache/hbase-filesystem/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #16: HBASE-24989 [HBOSS] Some code cleanup
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #16:
URL: https://github.com/apache/hbase-filesystem/pull/16#discussion_r484860827
##########
File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/TreeLockManager.java
##########
@@ -231,25 +231,27 @@ private boolean retryBackoff(int retries) throws IOException {
* or write locks should be held by anyone on any child directory.
*
* @param path Path to lock
+ * @param depth Depth.DIRECTORY to look for locks on this path only, or Depth.RECURSIVE to
Review comment:
Thanks for reviewing it. Yes, and while checking on this, I realised there are 25 more javadoc warnings. Will work on all of them and push in the next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-filesystem] wchevreuil merged pull request #16: HBASE-24989 [HBOSS] Some code cleanup
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #16:
URL: https://github.com/apache/hbase-filesystem/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-filesystem] HorizonNet commented on a change in pull request #16: HBASE-24989 [HBOSS] Some code cleanup
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #16:
URL: https://github.com/apache/hbase-filesystem/pull/16#discussion_r484331550
##########
File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/TreeLockManager.java
##########
@@ -231,25 +231,27 @@ private boolean retryBackoff(int retries) throws IOException {
* or write locks should be held by anyone on any child directory.
*
* @param path Path to lock
+ * @param depth Depth.DIRECTORY to look for locks on this path only, or Depth.RECURSIVE to
Review comment:
Would it be better to use a Javadoc link for the `Depth` parts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org