You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/19 13:00:34 UTC
[GitHub] [airflow] mnojek opened a new issue #17727: Duplicated general notifications in Airflow UI above DAGs list
mnojek opened a new issue #17727:
URL: https://github.com/apache/airflow/issues/17727
**Apache Airflow version**:
2.2.0.dev0 (possible older versions too)
**OS**:
Linux Debian 11
(BTW Here we have a typo in comment inside bug report template in `.github/ISSUE_TEMPLATE/bug_report.md`: `cat /etc/oss-release` <- double 's'.)
**Apache Airflow Provider versions**: -
**Deployment**:
Docker-compose 1.25.0
**What happened**:
The issue is related to Airflow UI and it shows duplicated notifications when removing all the tags from the input after filtering DAGs.
**What you expected to happen**:
The notifications should not be duplicated.
**How to reproduce it**:
In the main view, above the list of the DAGs (just below the top bar menu), there is a place where notifications appear. Suppose that there are 2 notifications (no matter which). Now try to search DAGs by tag using 'Filter DAGs by tag' input and use a valid tag. After the filtering is done, clear the input either by clicking on 'x' next to the tag or on the 'x' near the right side of the input. Notice that the notifications are duplicated and now you have 4 instead of 2 (each one is displayed twice). The input id is `s2id_autogen1`.
This bug happens only if all the tags are removed from the filtering input. If you remove the tag while there is still another one in the input, the bug will not appear. Also, it is not present while searching DAGs by name using the input 'Search DAGs'.
After search, before removing tags from input:
Duplicated notifications after removing tag from input:
**Are you willing to submit a PR?**
I can try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-925688873
Instead of moving the cookies around, we probably need to use a regular alert instead of flash and render those after the redirects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mnojek commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
mnojek commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-904584535
@potiuk I submitted a PR for the typos #17809. Nothing very important there, just some grammar/typo fixes and also the `os-release` command in the bug_report template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-901958433
Funny bug :)
> (BTW Here we have a typo in comment inside bug report template in .github/ISSUE_TEMPLATE/bug_report.md: cat /etc/oss-release <- double 's'.)
Maybe PR fixing it @mnojek ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-923872727
This also happens when the flask cookie tries to add tags that exist in the cookie but not in the url. I think we should just get rid of that cookie entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-901894584
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-912476971
This is happening when we redirect the home page to itself on this [line](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L581).
Is there a better way we can clean up the filter tags cookie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
ashb closed issue #17727:
URL: https://github.com/apache/airflow/issues/17727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mnojek commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list
Posted by GitBox <gi...@apache.org>.
mnojek commented on issue #17727:
URL: https://github.com/apache/airflow/issues/17727#issuecomment-901960616
@potiuk You mean this small issue in bug report template? I can do it tomorrow with other small typos across the documentation that I found while reading it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org