You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "SiyaoIsHiding (via GitHub)" <gi...@apache.org> on 2024/10/28 21:25:33 UTC
[PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
SiyaoIsHiding opened a new pull request, #106:
URL: https://github.com/apache/cassandra-builds/pull/106
1. Add ignoreTargetOnlyChanges(true) so that PRs do not automatically rerun every time target branch is updated
2. Download cassandra binaries when building docker images so that `ccm create` will not time out
Will need to install plugin [Basic Branch Build Strategies](https://plugins.jenkins.io/basic-branch-build-strategies/) to ci-cassandra jenkins server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1820132941
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
We do something like this for the internal Jenkins runners @SiyaoIsHiding ... check with me tomorrow and I can point you to the right place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1823225576
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
Thanks! They are both helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1820281973
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
there's kinda an example here: https://github.com/apache/cassandra/blob/trunk/.build/docker/ubuntu2004_test.docker#L129
(but sounds like what @absurdfarce has is more applicable, and tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2448171199
Thank you for educating me!! I watched that video and learned so much from it.
Is there anything else about git practice that you want me to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1819883250
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
Do you happen to know an existing snippet parsing those version strings and output the latest versions?
I would love to update the `Jenkins-asf` file to figure out the latest version in the same way, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1819842619
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
be aware these will quickly be out of date (not the latest patch) versions.
it should be possible to find these values dynamically via https://downloads.apache.org/cassandra/
(that would mean you only have to rebuild and publish after each new patch version, rather than edit this file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2449835722
deployed images with
```
docker buildx build --platform linux/amd64,linux/arm64 -t apache/cassandra-java-driver-testing-ubuntu2204 -t apache.jfrog.io/cassan-docker/apache/cassandra-java-driver-testing-ubuntu2204 -f ubuntu2204_java_driver_testing.docker --push .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#discussion_r1819842619
##########
docker/testing/ubuntu2204_java_driver_testing.docker:
##########
@@ -53,4 +53,12 @@ RUN git clone https://github.com/riptano/ccm.git && \
cd ccm && \
pip install -e .
+# download cassandra binaries
+RUN ccm create download -v 3.11.17 && \
+ ccm remove && \
+ ccm create download -v 4.0.14 && \
+ ccm remove && \
+ ccm create download -v 5.0.2 && \
+ ccm remove
Review Comment:
be aware these will quickly be out of date (not the latest patch) versions.
it should be possible to find these values dynamically via https://downloads.apache.org/cassandra/ (and https://archive.apache.org/dist/cassandra/ )
(that would mean you only have to rebuild and publish after each new patch version, rather than edit this file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2454239069
merged as https://github.com/apache/cassandra-builds/commit/9a52bf7ac1dc0f1e89a0aa79473ef3339cb50b8f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever closed pull request #106: CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver
URL: https://github.com/apache/cassandra-builds/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "SiyaoIsHiding (via GitHub)" <gi...@apache.org>.
SiyaoIsHiding commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2448176677
Got green run here: http://35.228.140.106:8080/blue/organizations/jenkins/multi-branch-java-driver/detail/asf-ci/28/pipeline/95/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSJAVA-25: Build a public CI for Apache Cassandra Java Driver [cassandra-builds]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #106:
URL: https://github.com/apache/cassandra-builds/pull/106#issuecomment-2443489583
A small ask @SiyaoIsHiding .
Can we avoid the `'Merge branch 'trunk' into SiyaoIsHiding/trunk'` type of commits please.
These end up leaving merge commits in opposing directions in the mainlines, and can make life hard. (It's better if you rebase your dev branch (and force push) instead. No one objects if you're force pushing your own branch for this reason. )
( _If interested_ there's some great theory here by Laura Wingerd at http://www.youtube.com/watch?v=AJ-CpGsCpM0 . It's not exactly the practice what we do in C*, some of our terminology is different, but the same concepts are there. )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org