You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andralungu <gi...@git.apache.org> on 2015/10/22 21:43:23 UTC
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1291
[FLINK-2634] [gelly] [WIP] Vertex Centric Triangle Count
This PR builds on the code presented in #1105.
Basically, the reduceOn* calls are replaced with groupReduceOn* calls.
As discussed back then, I made the lib method accept any kind of keys. While doing so, I found a bit of a bug (which is why I marked this as WIP). The groupReduceOnNeighbors function has a version that takes a type argument. The problem with that is: coGroup tries to build a type before the call to `returns()` which means that it cannot infer the type from the info it has.
I'll explain this a bit better in a Jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink trianglecount-vertexcentric
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1291
----
commit 1fbc09ca35e80f61f31cf7a6166f27f2a6f142c1
Author: andralungu <lu...@gmail.com>
Date: 2015-10-22T06:18:43Z
[FLINK-2634] [gelly] Vertex Centric Triangle Count
[FLINK-2634] [gelly] Fixed Type Erasure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172475425
Thanks @andralungu! Maybe you could open a PR with the bugfix only? Is there a jira for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/1291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172497724
Yes there is, and there have been some comments on that.
I am not sure that it's the best approach. I suggested some workarounds.
So actually that bugfix + this PR would have been a valid addition, but since nobody wanted to pick the bugfix task, I decided to close the pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172196411
Hey @andralungu,
is this something you'd like to continue working on? If not, would you mind closing this PR?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2634] [gelly] [WIP] Vertex Centric Tria...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172458727
Hi @vasia,
This PR contained a bugfix that could have been validated, but I don't mind closing it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---