You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/08/10 02:05:00 UTC

[kudu-CR] transaction: remove unused StatusTransactionCompletionCallback

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7632

Change subject: transaction: remove unused StatusTransactionCompletionCallback
......................................................................

transaction: remove unused StatusTransactionCompletionCallback

This has been unused since 899bde406ef16e84b930c7232ba9b25e7fab44f6.

Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
---
M src/kudu/tablet/transactions/transaction.h
1 file changed, 0 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/7632/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] transaction: remove unused StatusTransactionCompletionCallback

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: transaction: remove unused StatusTransactionCompletionCallback
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] transaction: remove unused StatusTransactionCompletionCallback

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: transaction: remove unused StatusTransactionCompletionCallback
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] transaction: remove unused StatusTransactionCompletionCallback

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: transaction: remove unused StatusTransactionCompletionCallback
......................................................................


transaction: remove unused StatusTransactionCompletionCallback

This has been unused since 899bde406ef16e84b930c7232ba9b25e7fab44f6.

Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
Reviewed-on: http://gerrit.cloudera.org:8080/7632
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/tablet/transactions/transaction.h
1 file changed, 0 insertions(+), 14 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3345b459637f170808e0d73c12a6754c6c2da31
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>