You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/04 16:25:14 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

ephraimbuddy opened a new pull request #19407:
URL: https://github.com/apache/airflow/pull/19407


   While troubleshooting another issue, I found that when a task is mark
   failed in the UI, the LocalTaskJob will still be in the running state
   for a long time.
   
   This is not a problem but when you mark many task instances as failed
   you will have a lot of hanging LocalTaskJob waiting for Zombie killer
   to kill it. I got to a point that Scheduler crashes with FATAL:too-many-clients error
   
   In this PR, I set the LocalTaskJob state to terminating so that the next
   heartbeat will do the clean-up.
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy closed pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #19407:
URL: https://github.com/apache/airflow/pull/19407


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy closed pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #19407:
URL: https://github.com/apache/airflow/pull/19407


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19407:
URL: https://github.com/apache/airflow/pull/19407#issuecomment-961717665


   Closing, seems i did something wrong that caused the LocalTaskJobs to not end


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19407:
URL: https://github.com/apache/airflow/pull/19407#issuecomment-961717665


   Closing, seems i did something wrong that caused the LocalTaskJobs to not end


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19407:
URL: https://github.com/apache/airflow/pull/19407#issuecomment-961717665


   Closing, seems i did something wrong that caused the LocalTaskJobs to not end


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy closed pull request #19407: Also terminate LocalTaskJob when taskrunner is being terminated

Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #19407:
URL: https://github.com/apache/airflow/pull/19407


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org