You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2013/05/10 01:06:13 UTC
[jira] [Updated] (LUCENE-2171) Over synchronization for read-only
index readers in SegmentTermDocs
[ https://issues.apache.org/jira/browse/LUCENE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2171:
----------------------------------
Fix Version/s: (was: 4.3)
4.4
> Over synchronization for read-only index readers in SegmentTermDocs
> -------------------------------------------------------------------
>
> Key: LUCENE-2171
> URL: https://issues.apache.org/jira/browse/LUCENE-2171
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Affects Versions: 2.9.1, 3.0
> Reporter: Jayson Minard
> Priority: Minor
> Fix For: 4.4
>
>
> In SegmentTermDocs constructor (from 2.9.1)
> {code}
> 46 protected SegmentTermDocs(SegmentReader parent) {
> 47 this.parent = parent;
> 48 this.freqStream = (IndexInput) parent.core.freqStream.clone();
> 49 synchronized (parent) {
> 50 this.deletedDocs = parent.deletedDocs;
> 51 }
> 52 this.skipInterval = parent.core.getTermsReader().getSkipInterval();
> 53 this.maxSkipLevels = parent.core.getTermsReader().getMaxSkipLevels();
> 54 }
> {code}
> The synchronization on "parent" for accessing deletedDocs is unnecessary on readonly indexes. If that access was moved into the SegmentReader then it could be protected there by default and overridden in ReadonlySegmentReader.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org