You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/23 07:27:08 UTC

[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1387: [IOTDB-709] Create schema automatically

LebronAl commented on a change in pull request #1387:
URL: https://github.com/apache/incubator-iotdb/pull/1387#discussion_r444014901



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java
##########
@@ -1667,6 +1710,18 @@ TSStatus forwardPlan(List<PartitionGroup> partitionGroups, PhysicalPlan plan) {
         status = forwardPlan(plan, partitionGroup);
       }
       if (status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
+        if (plan instanceof InsertPlan

Review comment:
       It seems that this function `forwardPlan` will only be used in `processNonPartitionedDataPlan`, which will be called only when the type of plan is `DeletePlan` or `DeleteTimeSeriesPlan`, so maybe these new code in this function is useless?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org