You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/10/14 16:28:45 UTC
[PR] refactor: deduplicate `concat` string and binary builders [datafusion]
andygrove opened a new pull request, #26318:
URL: https://github.com/apache/datafusion/pull/26318
## Which issue does this PR close?
- Closes #26304.
## Rationale for this change
`concat` and `concat_ws` build their output with an offset-based and a view builder for strings in `strings.rs`, and copies of both for binary in `binaries.rs`. The copies differ only in the output type, the UTF-8 check on scalars and `.as_bytes()` on string values, so a fix to one of them, such as to the view layout in `append_offset`, has to be made twice.
## What changes are included in this PR?
- `ConcatByteArrayBuilder<T>` replaces `ConcatGenericStringBuilder<O>` and `ConcatGenericBinaryBuilder<O>`, and `ConcatByteViewBuilder<T: ByteViewType>` replaces `ConcatStringViewBuilder` and `ConcatBinaryViewBuilder`. Arrow's `ByteArrayType` and `ByteViewType` already give the data type and the array to build, so `finish` is shared too, with one `SAFETY` comment.
- The one new trait, `ConcatByteArrayType`, adds to `ByteArrayType` the `IS_UTF8` constant that `ByteViewType` already has. `T::DATA_TYPE.is_string()` folds to the right constant, but still builds a `DataType` and calls its out-of-line destructor on every call, which made `concat` on `Binary` about 10% slower.
- `ColumnarValueRef::write_bytes` replaces the four per-builder matches over the input column. As before, string outputs take string arrays and UTF-8 scalars, and binary outputs take binary arrays and any scalar, which is what the unchecked constructors in `finish` rely on. It passes the bytes to a closure, so each arm appends directly as before. Returning an `Option<&[u8]>` instead, which sent every arm through one shared append, made `concat` up to 12% slower.
- The six builder names stay as type aliases, so `concat.rs` and `concat_ws.rs` are unchanged and the binary aliases stay in `binaries.rs`.
- The view builders' `append_offset` uses `MAX_INLINE_LEN` instead of a literal 12.
The internal error for an input of the wrong type no longer distinguishes the view builders: it says "string builder" or "binary builder".
## What is the testing strategy for this PR?
- The string builders are covered by the existing `concat` and `concat_ws` tests, including `string_query.slt.part`, which runs on `Utf8`, `LargeUtf8` and `Utf8View` columns. The binary builders were only reached by a one-row `Binary` table, so `string/concat.slt` gets cases that run both functions on `Binary`, `LargeBinary` and `BinaryView` columns, with a NULL value, a NULL separator, a non-UTF-8 literal, and a 13-byte `BinaryView` result, one byte over the inline limit. They pass on `main` too. Raising the builder's inline limit by one makes the 13-byte row come back with another row's bytes.
- New unit test `concat_builders_check_input_types` checks which inputs each of the six builders accepts. Coercion keeps SQL from reaching the rejected ones, but those checks are what keep the unchecked constructors sound. Removing the UTF-8 check on scalars, or the guard on one binary arm, fails it.
- `cargo test --profile ci --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption`, excluding the examples, benchmarks and CLI crates, passes, as does the full sqllogictest suite.
`concat` and `concat_ws` benchmarks against `main`, the median of five interleaved runs of each binary on an Apple M3 Max that was busy with other work:
| Case | `main` | This PR | Change |
| --- | --- | --- | --- |
| `concat`, `Utf8`, 1024 rows | 18.1 µs | 17.8 µs | −1.6% |
| `concat`, `Utf8`, 4096 rows | 71.6 µs | 69.8 µs | −2.4% |
| `concat`, `Utf8`, 8192 rows | 143.3 µs | 139.4 µs | −2.7% |
| `concat`, `Utf8View`, 1024 rows | 27.7 µs | 27.5 µs | −0.6% |
| `concat`, `Utf8View`, 4096 rows | 123.6 µs | 123.2 µs | −0.3% |
| `concat`, `Utf8View`, 8192 rows | 269.1 µs | 262.6 µs | −2.4% |
| `concat`, scalar | 621 ns | 648 ns | +4.3% |
| `concat_ws`, `Utf8`, 1024 rows | 24.5 µs | 23.4 µs | −4.3% |
| `concat_ws`, `Utf8`, 4096 rows | 95.7 µs | 93.4 µs | −2.4% |
| `concat_ws`, `Utf8`, 8192 rows | 191.6 µs | 185.1 µs | −3.4% |
| `concat_ws`, scalar | 646 ns | 622 ns | −3.7% |
| `concat`, `LargeUtf8`, 8192 rows | 144.5 µs | 144.6 µs | +0.0% |
| `concat`, `Binary`, 8192 rows | 126.7 µs | 128.8 µs | +1.7% |
| `concat`, `LargeBinary`, 8192 rows | 124.3 µs | 129.0 µs | +3.7% |
| `concat`, `BinaryView`, 8192 rows | 176.8 µs | 168.1 µs | −4.9% |
| `concat_ws`, `LargeUtf8`, 8192 rows | 192.1 µs | 186.8 µs | −2.8% |
| `concat_ws`, `Binary`, 8192 rows | 174.5 µs | 167.3 µs | −4.2% |
| `concat_ws`, `LargeBinary`, 8192 rows | 171.3 µs | 167.8 µs | −2.0% |
| `concat_ws`, `BinaryView`, 8192 rows | 208.0 µs | 205.3 µs | −1.3% |
The existing benchmarks only cover `Utf8` and `Utf8View`, so the last eight rows come from a temporary local benchmark, not included here, that runs `concat(a, ', ', a)` and `concat_ws(', ', a, a)` the same way. The scalar cases don't use the builders, so they show the noise level of this run.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6175259897
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/26318#issuecomment-6175211323)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c6175211323-3398-w26xh 6.12.94+ #1 SMP Fri Aug 21 08:00:16 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing andygrove/dedupe-concat-builders (1301f86d35be41efd34c0dc9ce972d9740293a15) to 0d79252 (merge-base) [diff](https://github.com/apache/datafusion/compare/0d79252f61bd8777990b2749c216ffd07079c30d..1301f86d35be41efd34c0dc9ce972d9740293a15)
<details><summary>Run configuration</summary>
```yaml
run benchmark string_expressions
env:
BENCH_FILTER: "concat"
```
</details>
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6176227897
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/26318#issuecomment-6176075808)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing andygrove/dedupe-concat-builders (1301f86d35be41efd34c0dc9ce972d9740293a15) to 0d79252 (merge-base) [diff](https://github.com/apache/datafusion/compare/0d79252f61bd8777990b2749c216ffd07079c30d..1301f86d35be41efd34c0dc9ce972d9740293a15)
<details><summary>Run configuration</summary>
```yaml
run benchmark string_expressions
env:
BENCH_FILTER: "concat"
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group HEAD andygrove_dedupe-concat-builders
----- ---- --------------------------------
concat function/concat/1024 1.07 14.6±0.02µs ? ?/sec 1.00 13.6±0.02µs ? ?/sec
concat function/concat/4096 1.06 57.5±0.09µs ? ?/sec 1.00 54.3±0.09µs ? ?/sec
concat function/concat/8192 1.06 114.7±0.26µs ? ?/sec 1.00 108.5±0.27µs ? ?/sec
concat function/concat/scalar 1.00 820.1±2.23ns ? ?/sec 1.00 820.2±1.03ns ? ?/sec
concat function/concat_view/1024 1.02 30.6±0.27µs ? ?/sec 1.00 30.0±0.05µs ? ?/sec
concat function/concat_view/4096 1.02 138.9±1.38µs ? ?/sec 1.00 135.9±0.28µs ? ?/sec
concat function/concat_view/8192 1.04 306.0±3.25µs ? ?/sec 1.00 294.9±0.96µs ? ?/sec
concat_ws function/concat_ws/1024 1.00 20.5±0.06µs ? ?/sec 1.04 21.3±0.02µs ? ?/sec
concat_ws function/concat_ws/4096 1.00 79.9±0.08µs ? ?/sec 1.04 83.0±0.09µs ? ?/sec
concat_ws function/concat_ws/8192 1.00 159.4±0.98µs ? ?/sec 1.04 165.2±0.18µs ? ?/sec
concat_ws function/concat_ws/scalar 1.00 969.9±1.14ns ? ?/sec 1.00 974.7±2.52ns ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**string_expressions — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 185.0s |
| Peak memory | 37.6 MiB |
| Avg memory | 18.4 MiB |
| CPU user | 138.1s |
| CPU sys | 0.1s |
| Peak spill | 0 B |
**string_expressions — branch**
| Metric | Value |
|--------|-------|
| Wall time | 175.0s |
| Peak memory | 38.3 MiB |
| Avg memory | 20.3 MiB |
| CPU user | 136.7s |
| CPU sys | 0.2s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6175507374
🤖 Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/26318#issuecomment-6175211323)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing andygrove/dedupe-concat-builders (1301f86d35be41efd34c0dc9ce972d9740293a15) to 0d79252 (merge-base) [diff](https://github.com/apache/datafusion/compare/0d79252f61bd8777990b2749c216ffd07079c30d..1301f86d35be41efd34c0dc9ce972d9740293a15)
<details><summary>Run configuration</summary>
```yaml
run benchmark string_expressions
env:
BENCH_FILTER: "concat"
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group HEAD andygrove_dedupe-concat-builders
----- ---- --------------------------------
concat function/concat/1024 1.08 14.6±0.04µs ? ?/sec 1.00 13.6±0.03µs ? ?/sec
concat function/concat/4096 1.06 57.5±0.07µs ? ?/sec 1.00 54.1±0.11µs ? ?/sec
concat function/concat/8192 1.06 114.8±0.20µs ? ?/sec 1.00 108.7±1.35µs ? ?/sec
concat function/concat/scalar 1.00 802.2±1.31ns ? ?/sec 1.02 819.8±0.98ns ? ?/sec
concat function/concat_view/1024 1.03 30.9±0.24µs ? ?/sec 1.00 30.1±0.18µs ? ?/sec
concat function/concat_view/4096 1.03 139.5±1.08µs ? ?/sec 1.00 135.6±0.39µs ? ?/sec
concat function/concat_view/8192 1.03 303.5±2.78µs ? ?/sec 1.00 294.4±0.70µs ? ?/sec
concat_ws function/concat_ws/1024 1.00 20.5±0.03µs ? ?/sec 1.04 21.3±0.04µs ? ?/sec
concat_ws function/concat_ws/4096 1.00 79.9±0.06µs ? ?/sec 1.04 83.1±0.12µs ? ?/sec
concat_ws function/concat_ws/8192 1.00 158.8±0.41µs ? ?/sec 1.04 165.7±0.46µs ? ?/sec
concat_ws function/concat_ws/scalar 1.00 960.9±1.66ns ? ?/sec 1.00 961.4±2.54ns ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**string_expressions — base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 410.1s |
| Peak memory | 35.4 MiB |
| Avg memory | 8.1 MiB |
| CPU user | 134.8s |
| CPU sys | 0.1s |
| Peak spill | 0 B |
**string_expressions — branch**
| Metric | Value |
|--------|-------|
| Wall time | 370.1s |
| Peak memory | 39.3 MiB |
| Avg memory | 9.9 MiB |
| CPU user | 133.8s |
| CPU sys | 0.1s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6176110078
🤖 Benchmark running (GKE) | [trigger](https://github.com/apache/datafusion/pull/26318#issuecomment-6176075808)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c6176075808-3404-z5lhp 6.12.94+ #1 SMP Fri Aug 21 08:00:16 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing andygrove/dedupe-concat-builders (1301f86d35be41efd34c0dc9ce972d9740293a15) to 0d79252 (merge-base) [diff](https://github.com/apache/datafusion/compare/0d79252f61bd8777990b2749c216ffd07079c30d..1301f86d35be41efd34c0dc9ce972d9740293a15)
<details><summary>Run configuration</summary>
```yaml
run benchmark string_expressions
env:
BENCH_FILTER: "concat"
```
</details>
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6175663520
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26318?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.81%. Comparing base ([`0d79252`](https://app.codecov.io/gh/apache/datafusion/commit/0d79252f61bd8777990b2749c216ffd07079c30d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1301f86`](https://app.codecov.io/gh/apache/datafusion/commit/1301f86d35be41efd34c0dc9ce972d9740293a15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #26318 +/- ##
==========================================
+ Coverage 82.80% 82.81% +0.01%
==========================================
Files 1149 1148 -1
Lines 454146 454064 -82
Branches 454146 454064 -82
==========================================
+ Hits 376035 376036 +1
+ Misses 55260 55180 -80
+ Partials 22851 22848 -3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26318?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6176075808
run benchmark string_expressions
```yaml
env:
BENCH_FILTER: concat
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #26318:
URL: https://github.com/apache/datafusion/pull/26318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: deduplicate `concat` string and binary builders [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26318:
URL: https://github.com/apache/datafusion/pull/26318#issuecomment-6175211323
run benchmark string_expressions
```yaml
env:
BENCH_FILTER: concat
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org