You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/24 15:25:01 UTC
[jira] [Commented] (STANBOL-1468) Inconsistent method name "toLRU"
[ https://issues.apache.org/jira/browse/STANBOL-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450055#comment-16450055 ]
ASF GitHub Bot commented on STANBOL-1468:
-----------------------------------------
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/stanbol/pull/7
STANBOL-1468: Change the method name.
The method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/stanbol trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stanbol/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 156cbfd034948e6805bc32be9a4e31c3366c48c8
Author: Kui LIU <br...@...>
Date: 2018-04-24T15:23:51Z
STANBOL-1468: Change the method name.
The method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.
----
> Inconsistent method name "toLRU"
> --------------------------------
>
> Key: STANBOL-1468
> URL: https://issues.apache.org/jira/browse/STANBOL-1468
> Project: Stanbol
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
> Attachments: rename-method.patch
>
>
> The following method "toLRU" is adding the data of the paraement 'r' to the variable "lru", but it is named "toLRU". "toLRU" seems to mean that converting one object to another one, so that "toLRU" may be confusing. "addToLRU" should be better.
> {code:java}
> private void toLRU(Representation r){
> lru.put(r.getId(), r);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)