You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/05 05:13:30 UTC
[GitHub] [druid] gianm commented on a change in pull request #9310: Remove
EasyMock dependency from CalciteTests.
gianm commented on a change in pull request #9310: Remove EasyMock dependency from CalciteTests.
URL: https://github.com/apache/druid/pull/9310#discussion_r375062378
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java
##########
@@ -129,20 +133,24 @@
import org.apache.druid.sql.calcite.view.ViewManager;
import org.apache.druid.timeline.DataSegment;
import org.apache.druid.timeline.partition.LinearShardSpec;
-import org.easymock.EasyMock;
Review comment:
Hmm, probably either modify FakeDruidNodeDiscoveryProvider to return actual servers (it's a simple thing to subclass, or restore EasyMock in druid-sql and find another way to solve the original problem (https://github.com/apache/druid/pull/9308#issuecomment-582128976) — a suppression or something else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org