You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2012/06/28 05:05:42 UTC
[jira] [Created] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Chris Male created LUCENE-4173:
----------------------------------
Summary: Remove IgnoreIncompatibleGeometry for SpatialStrategys
Key: LUCENE-4173
URL: https://issues.apache.org/jira/browse/LUCENE-4173
Project: Lucene - Java
Issue Type: Bug
Components: modules/spatial
Reporter: Chris Male
Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-4173:
-------------------------------
Attachment: LUCENE-4173.patch
Simple patch removing the option and improving how non-Point shapes are handled in TwoDoubles.
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Attachments: LUCENE-4173.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-4173:
---------------------------------
Attachment: LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
This patch removes ignoreIncompatibleGeometry and modified the strategies to fail when given a shape that isn't the precise shape used -- no coalescing. BBox & TwoDoubles were both doing coalescing (e.g. shape.getBoundingBox()). PrefixTree can handle anything so change there.
I'll commit this pending your +1 Chris.
An enum for FAIL, COALESCE, or IGNORE can be done in another issue if desired.
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Attachments: LUCENE-4173.patch, LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-4173:
---------------------------------
Attachment: LUCENE-4173_remove_IgnoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
Updated the patch:
* renamed the test method with the underscore to be "convertShapeFromGetDocuments" instead
* In BBoxStrategy.makeValueSource, I moved my "TODO" bbox shape similarity idea to a comment on a JIRA issue. And I modified this makeValueSource to fail if a rectangle is not given, instead of coalescing via getBoundingBox().
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Fix For: 4.0
>
> Attachments: LUCENE-4173.patch, LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch, LUCENE-4173_remove_IgnoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley resolved LUCENE-4173.
----------------------------------
Resolution: Fixed
I received Chris's blessing on these changes in chat and I committed now.
Trunk: r1384026, 4x: r1384028
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Fix For: 4.0
>
> Attachments: LUCENE-4173.patch, LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch, LUCENE-4173_remove_IgnoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (LUCENE-4173) Remove
IgnoreIncompatibleGeometry for SpatialStrategys
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453312#comment-13453312 ]
David Smiley edited comment on LUCENE-4173 at 9/12/12 8:38 AM:
---------------------------------------------------------------
This patch removes ignoreIncompatibleGeometry and modified the strategies to fail when given a shape that isn't the precise shape used -- no coalescing. BBox & TwoDoubles were both doing coalescing (e.g. shape.getBoundingBox()). PrefixTree can handle anything so no change there.
I'll commit this pending your +1 [~cmale].
An enum for FAIL, COALESCE, & IGNORE can be done in another issue if desired.
was (Author: dsmiley):
This patch removes ignoreIncompatibleGeometry and modified the strategies to fail when given a shape that isn't the precise shape used -- no coalescing. BBox & TwoDoubles were both doing coalescing (e.g. shape.getBoundingBox()). PrefixTree can handle anything so change there.
I'll commit this pending your +1 Chris.
An enum for FAIL, COALESCE, or IGNORE can be done in another issue if desired.
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Attachments: LUCENE-4173.patch, LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4173) Remove IgnoreIncompatibleGeometry
for SpatialStrategys
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley updated LUCENE-4173:
---------------------------------
Fix Version/s: 4.0
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
> Key: LUCENE-4173
> URL: https://issues.apache.org/jira/browse/LUCENE-4173
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Fix For: 4.0
>
> Attachments: LUCENE-4173.patch, LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay. Users should get an Exception and then they can decide how to proceed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org