You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Hongchao Deng <hd...@cloudera.com> on 2014/09/24 02:17:44 UTC

Review Request 25968: ZOOKEEPER-2019

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25968/
-----------------------------------------------------------

Review request for zookeeper.


Repository: zookeeper-git


Description
-------

ZOOKEEPER-2019


Diffs
-----

  src/java/main/org/apache/zookeeper/StatsTrack.java 623c6d4 
  src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 
  src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 
  src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java 70a1486 

Diff: https://reviews.apache.org/r/25968/diff/


Testing
-------


Thanks,

Hongchao Deng

Re: Review Request 25968: ZOOKEEPER-2019

Posted by Rakesh R <ra...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25968/#review69772
-----------------------------------------------------------



src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/25968/#comment114585>

    Please update javadocs as per the new method singature



src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/25968/#comment114582>

    logging: use {} instead of + for concatenation



src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/25968/#comment114583>

    logging: use {} instead of + for concatenation



src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/25968/#comment114584>

    logging: use {} instead of + for concatenation. Same comments applicable to many places. Please modify. Thanks!



src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/25968/#comment114586>

    rename variable to follow naming conventions like,
    newBytes and oldBytes



src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java
<https://reviews.apache.org/r/25968/#comment114587>

    please remove 'limits' variable, its unused


- Rakesh R


On Sept. 24, 2014, 4:22 a.m., Hongchao Deng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25968/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 4:22 a.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> ZOOKEEPER-2019
> 
> 
> Diffs
> -----
> 
>   src/java/main/org/apache/zookeeper/StatsTrack.java 623c6d4 
>   src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 
>   src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 
>   src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java 70a1486 
> 
> Diff: https://reviews.apache.org/r/25968/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hongchao Deng
> 
>

Re: Review Request 25968: ZOOKEEPER-2019

Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25968/
-----------------------------------------------------------

(Updated Sept. 24, 2014, 4:22 a.m.)


Review request for zookeeper.


Repository: zookeeper-git


Description
-------

ZOOKEEPER-2019


Diffs (updated)
-----

  src/java/main/org/apache/zookeeper/StatsTrack.java 623c6d4 
  src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 
  src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 
  src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java 70a1486 

Diff: https://reviews.apache.org/r/25968/diff/


Testing
-------


Thanks,

Hongchao Deng