[GitHub] [hudi] nsivabalan commented on a change in pull request #2111: [HUDI-1234] Insert new records to data files without merging for "Insert" operation.

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#discussion_r560681016



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -133,6 +133,10 @@
   private static final String MERGE_DATA_VALIDATION_CHECK_ENABLED = "hoodie.merge.data.validation.enabled";
   private static final String DEFAULT_MERGE_DATA_VALIDATION_CHECK_ENABLED = "false";
 
+  // Concats inserts to data files without merging
+  private static final String MERGE_ALLOW_DUPLICATE_INSERTS = "hoodie.merge.allow.duplicate.inserts";

Review comment:
       @vinothchandar : does the config name looks ok? somehow I feel it does not exactly convey the actual intent, but talks about the effect. For instance,
   something like "hoodie.concat.inserts.without.merge.on.insert" or "hoodie.concat.records.on.insert" etc. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org