You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/20 23:49:35 UTC
[GitHub] [incubator-gobblin] htran1 opened a new pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
htran1 opened a new pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208
…in the AzkabanJobLauncher
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1366
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
The AzkabanJobLauncher was changed recently to remove the dependency on the job type for determining token initialization.
This breaks some use cases where no tokens are required.
Add the gobblin.initializeHadoopTokens option with a default of true to allow opting out of token initialization.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208#discussion_r561588618
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -112,6 +112,9 @@
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "-1"; // No SLA.
+ public static final String GOBBLIN_INITIALIZE_HADOOP_TOKENS = "gobblin.initializeHadoopTokens";
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208#discussion_r561588618
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -112,6 +112,9 @@
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "-1"; // No SLA.
+ public static final String GOBBLIN_INITIALIZE_HADOOP_TOKENS = "gobblin.initializeHadoopTokens";
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] aplex commented on a change in pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208#discussion_r561438129
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -112,6 +112,9 @@
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "-1"; // No SLA.
+ public static final String GOBBLIN_INITIALIZE_HADOOP_TOKENS = "gobblin.initializeHadoopTokens";
Review comment:
The property above uses "gobblin.azkaban" prefix. Should we use the same prefix here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] aplex commented on a change in pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208#discussion_r561438129
##########
File path: gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -112,6 +112,9 @@
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "-1"; // No SLA.
+ public static final String GOBBLIN_INITIALIZE_HADOOP_TOKENS = "gobblin.initializeHadoopTokens";
Review comment:
The property above uses "gobblin.azkaban" prefix. Should we use the same prefix here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3208: [GOBBLIN-1366] Add an option to skip initialization of hadoop tokens …
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org