You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/17 14:16:29 UTC
[GitHub] [dubbo-getty] AlexStocks opened a new pull request #56: Ftr: delete session.handleLoop
AlexStocks opened a new pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
delete session.handleLoop to decrease a goroutine of tcp session
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] pantianying commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
pantianying commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r663665395
##########
File path: benchmark/client/main.go
##########
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+ "encoding/binary"
+ "errors"
+ "flag"
+ "fmt"
+ "log"
+ "net"
+ "sync"
+ "sync/atomic"
+ "time"
+)
+
+import (
+ "github.com/apache/dubbo-getty"
+ "github.com/dubbogo/gost/sync"
+ "github.com/montanaflynn/stats"
+)
+
+var (
+ concurrency = flag.Int("c", 1, "concurrency")
+ total = flag.Int("n", 1, "total requests for all clients")
+ ip = flag.String("ip", "127.0.0.1:8090", "server IP")
+ connections = flag.Int("conn", 1, "number of tcp connections")
+
+ taskPoolMode = flag.Bool("taskPool", false, "task pool mode")
+ taskPoolSize = flag.Int("task_pool_size", 2000, "task poll size")
+ pprofPort = flag.Int("pprof_port", 65431, "pprof http port")
+)
+
+var taskPool gxsync.GenericTaskPool
+
+const (
+ CronPeriod = 20e9
+ WritePkgTimeout = 1e8
+)
+
+func main() {
+ flag.Parse()
+
+ n := *concurrency
+ m := *total / n
+
+ log.Printf("Servers: %+v\n\n", *ip)
+ log.Printf("concurrency: %d\nrequests per client: %d\n\n", n, m)
+
+ var wg sync.WaitGroup
+ wg.Add(n * m)
+
+ d := make([][]int64, n, n)
+ var trans uint64
+ var transOK uint64
+
+ totalT := time.Now().UnixNano()
+ for i := 0; i < n; i++ {
+ dt := make([]int64, 0, m)
+ d = append(d, dt)
+
+ go func(ii int) {
+ client := getty.NewTCPClient(
+ getty.WithServerAddress(*ip),
+ getty.WithConnectionNumber(*connections),
+ getty.WithClientTaskPool(taskPool),
+ )
+
+ var tmpSession getty.Session
+ NewHelloClientSession := func(session getty.Session) (err error) {
+ pkgHandler := &PackageHandler{}
+ EventListener := &MessageHandler{}
+
+ EventListener.SessionOnOpen = func(session getty.Session) {
+ tmpSession = session
+ }
+
+ tcpConn, ok := session.Conn().(*net.TCPConn)
+ if !ok {
+ panic(fmt.Sprintf("newSession: %s, session.conn{%#v} is not tcp connection", session.Stat(), session.Conn()))
+ }
+
+ if err = tcpConn.SetNoDelay(true); err != nil {
+ return err
+ }
+ if err = tcpConn.SetKeepAlive(true); err != nil {
+ return err
+ }
+ if err = tcpConn.SetKeepAlivePeriod(10 * time.Second); err != nil {
+ return err
+ }
+ if err = tcpConn.SetReadBuffer(262144); err != nil {
+ return err
+ }
+ if err = tcpConn.SetWriteBuffer(524288); err != nil {
+ return err
+ }
+
+ session.SetName("hello")
+ session.SetMaxMsgLen(128 * 1024) // max message package length is 128k
+ session.SetReadTimeout(time.Second)
+ session.SetWriteTimeout(5 * time.Second)
+ session.SetCronPeriod(int(CronPeriod / 1e6))
+ session.SetWaitTime(time.Second)
+
+ session.SetPkgHandler(pkgHandler)
+ session.SetEventListener(EventListener)
+ return nil
+ }
+
+ client.RunEventLoop(NewHelloClientSession)
+
+ for j := 0; j < m; j++ {
+ atomic.AddUint64(&trans, 1)
+
+ t := time.Now().UnixNano()
+ msg := buildSendMsg()
+ _, _, err := tmpSession.WritePkg(msg, WritePkgTimeout)
+ if err != nil {
+ log.Printf("Err:session.WritePkg(session{%s}, error{%v}", tmpSession.Stat(), err)
+ }
+
+ atomic.AddUint64(&transOK, 1)
Review comment:
atomic.AddUint64(&transOK, 1) should on err==nil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r571446582
##########
File path: session.go
##########
@@ -555,9 +530,7 @@ func (s *session) handlePackage() {
rBuf = rBuf[:runtime.Stack(rBuf, false)]
log.Errorf("[session.handlePackage] panic session %s: err=%s\n%s", s.sessionToken(), r, rBuf)
}
-
- close(s.rDone)
- grNum := atomic.AddInt32(&(s.grNum), -1)
+ grNum := s.grNum.Add(1)
Review comment:
`grNum := s.grNum.Add(1)` -> `grNum := s.grNum.Add(-1)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r611065297
##########
File path: client.go
##########
@@ -170,7 +171,7 @@ func (c *client) dialTCP() Session {
}
log.Infof("net.DialTimeout(addr:%s, timeout:%v) = error:%+v", c.addr, connectTimeout, perrors.WithStack(err))
- <-wheel.After(connectInterval)
+ <-gxtime.After(connectInterval)
Review comment:
`gxtime.After` 异常阻塞，影响重连，这个场景使用 `time.After` 可便于维护，1.14 对 time 有优化。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874855101
> this pr include the following changes:
>
> 1. replace `sync/atomic` using `go.uber.org/atomic`
> 2. upgrade `gxtime.Wheel` to `gxtime.TimerWheel`
> 3. delete session heartbeat loop handle, and add it into the `TimerWheel` instead to reduce the count of goroutines.
> 4. add benchmark code
Can not agree with u on suggestion 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874385436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874391547
this pr include the following changes:
1. replace `sync/atomic` using `go.uber.org/atomic`
2. upgrade `gxtime.Wheel` to `gxtime.TimerWheel`
3. delete session heartbeat loop handle, and add it into the `TimerWheel` instead to reduce the count of goroutines.
4. add benchmark code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r659883237
##########
File path: session.go
##########
@@ -462,6 +453,34 @@ func (s *session) WriteBytesArray(pkgs ...[]byte) (int, error) {
return wlg, nil
}
+func sessionTimerLoop(_ gxtime.TimerID, _ time.Time, arg interface{}) error {
Review comment:
@wenxuwan agree with u. @georgehao pls change this func name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874385436
@georgehao pls fix the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-869159450
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82b07be) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/f9499a7eebebf6d58ef41748d2aaf3a52a6ea5f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9499a7) will **decrease** coverage by `1.35%`.
> The diff coverage is `59.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 67.99% 66.64% -1.36%
==========================================
Files 8 8
Lines 1281 1256 -25
==========================================
- Hits 871 837 -34
- Misses 318 326 +8
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `67.71% <48.38%> (-3.49%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `65.71% <66.66%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `78.22% <86.95%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f9499a7...82b07be](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r611062237
##########
File path: session.go
##########
@@ -479,56 +498,12 @@ func (s *session) run() {
return
}
- // start read/write gr
- atomic.AddInt32(&(s.grNum), 2)
- go s.handleLoop()
- go s.handlePackage()
-}
-
-func (s *session) handleLoop() {
- var (
- wsFlag bool
- wsConn *gettyWSConn
- counter gxtime.CountWatch
- )
-
- defer func() {
- if r := recover(); r != nil {
- const size = 64 << 10
- rBuf := make([]byte, size)
- rBuf = rBuf[:runtime.Stack(rBuf, false)]
- log.Errorf("[session.handleLoop] panic session %s: err=%s\n%s", s.sessionToken(), r, rBuf)
- }
-
- grNum := atomic.AddInt32(&(s.grNum), -1)
- s.listener.OnClose(s)
- log.Infof("%s, [session.handleLoop] goroutine exit now, left gr num %d", s.Stat(), grNum)
- s.gc()
- }()
-
- wsConn, wsFlag = s.Connection.(*gettyWSConn)
-LOOP:
- for {
- select {
- case <-s.done:
- // this case branch assure the (session)handleLoop gr will exit after (session)handlePackage gr.
- <-s.rDone
- counter.Start()
- if counter.Count() > s.wait.Nanoseconds() {
- log.Infof("%s, [session.handleLoop] got done signal ", s.Stat())
- break LOOP
- }
-
- case <-wheel.After(s.period):
- if wsFlag {
- err := wsConn.writePing()
- if err != nil {
- log.Warnf("wsConn.writePing() = error:%+v", perrors.WithStack(err))
- }
- }
- s.listener.OnCron(s)
- }
+ s.grNum.Add(1)
+ if _, err := defaultTimerWheel.AddTimer(sessionTimerLoop, gxtime.TimerLoop, s.period, s); err != nil {
Review comment:
内存泄露，如果 session 关闭，该 session 的 `sessionTimerLoop` 还会一直被执行下去。需要清理资源
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-763774060
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc) (37ba965) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/30e62643dc9d44c3f10b7083ef000e5155e7f710?el=desc) (30e6264) will **decrease** coverage by `1.34%`.
> The diff coverage is `57.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 68.09% 66.74% -1.35%
==========================================
Files 8 8
Lines 1285 1260 -25
==========================================
- Hits 875 841 -34
- Misses 318 326 +8
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `68.01% <46.66%> (-3.45%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <50.00%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y29ubmVjdGlvbi5nbw==) | `78.22% <86.36%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer). Last update [30e6264...37ba965](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r664174265
##########
File path: session.go
##########
@@ -477,56 +495,12 @@ func (s *session) run() {
return
}
- // start read/write gr
- atomic.AddInt32(&(s.grNum), 2)
- go s.handleLoop()
- go s.handlePackage()
-}
-
-func (s *session) handleLoop() {
- var (
- wsFlag bool
- wsConn *gettyWSConn
- counter gxtime.CountWatch
- )
-
- defer func() {
- if r := recover(); r != nil {
- const size = 64 << 10
- rBuf := make([]byte, size)
- rBuf = rBuf[:runtime.Stack(rBuf, false)]
- log.Errorf("[session.handleLoop] panic session %s: err=%s\n%s", s.sessionToken(), r, rBuf)
- }
-
- grNum := atomic.AddInt32(&(s.grNum), -1)
- s.listener.OnClose(s)
- log.Infof("%s, [session.handleLoop] goroutine exit now, left gr num %d", s.Stat(), grNum)
- s.gc()
- }()
-
- wsConn, wsFlag = s.Connection.(*gettyWSConn)
-LOOP:
- for {
- select {
- case <-s.done:
- // this case branch assure the (session)handleLoop gr will exit after (session)handlePackage gr.
- <-s.rDone
- counter.Start()
- if counter.Count() > s.wait.Nanoseconds() {
- log.Infof("%s, [session.handleLoop] got done signal ", s.Stat())
- break LOOP
- }
-
- case <-wheel.After(s.period):
- if wsFlag {
- err := wsConn.writePing()
- if err != nil {
- log.Warnf("wsConn.writePing() = error:%+v", perrors.WithStack(err))
- }
- }
- s.listener.OnCron(s)
- }
+ s.grNum.Add(1)
Review comment:
move the statement `s.grNum.Add(1)` just before `go s.handlePackage()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks removed a comment on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
AlexStocks removed a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-874855101
> this pr include the following changes:
>
> 1. replace `sync/atomic` using `go.uber.org/atomic`
> 2. upgrade `gxtime.Wheel` to `gxtime.TimerWheel`
> 3. delete session heartbeat loop handle, and add it into the `TimerWheel` instead to reduce the count of goroutines.
> 4. add benchmark code
Can not agree with u on suggestion 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r659883237
##########
File path: session.go
##########
@@ -462,6 +453,34 @@ func (s *session) WriteBytesArray(pkgs ...[]byte) (int, error) {
return wlg, nil
}
+func sessionTimerLoop(_ gxtime.TimerID, _ time.Time, arg interface{}) error {
Review comment:
@wenxuwan agree with u. @georgehao pls change this func name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-763774060
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc) (a87169f) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ef4aaa4a30bd53a8daf26e325085b4bf954d9aee?el=desc) (ef4aaa4) will **decrease** coverage by `1.35%`.
> The diff coverage is `57.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 67.89% 66.53% -1.36%
==========================================
Files 8 8
Lines 1277 1252 -25
==========================================
- Hits 867 833 -34
- Misses 318 326 +8
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `67.63% <46.66%> (-3.50%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <50.00%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y29ubmVjdGlvbi5nbw==) | `77.98% <86.36%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer). Last update [ef4aaa4...a87169f](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-869159450
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4920f0c) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/3eb8b38bb0572be5e2ac243c7cd9c9874e66b2df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3eb8b38) will **decrease** coverage by `1.82%`.
> The diff coverage is `65.06%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 68.06% 66.24% -1.83%
==========================================
Files 8 8
Lines 1284 1256 -28
==========================================
- Hits 874 832 -42
- Misses 318 331 +13
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [const.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3QuZ28=) | `75.00% <ø> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [tls.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGxzLmdv) | `0.00% <ø> (ø)` | |
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `66.02% <52.50%> (-5.38%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `65.71% <66.66%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `78.96% <90.90%> (+0.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [03651ca...4920f0c](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wenxuwan commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r657880022
##########
File path: session.go
##########
@@ -462,6 +453,34 @@ func (s *session) WriteBytesArray(pkgs ...[]byte) (int, error) {
return wlg, nil
}
+func sessionTimerLoop(_ gxtime.TimerID, _ time.Time, arg interface{}) error {
Review comment:
change the name to heartbeat? the function name has no meaning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] wongoo commented on a change in pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#discussion_r664174265
##########
File path: session.go
##########
@@ -477,56 +495,12 @@ func (s *session) run() {
return
}
- // start read/write gr
- atomic.AddInt32(&(s.grNum), 2)
- go s.handleLoop()
- go s.handlePackage()
-}
-
-func (s *session) handleLoop() {
- var (
- wsFlag bool
- wsConn *gettyWSConn
- counter gxtime.CountWatch
- )
-
- defer func() {
- if r := recover(); r != nil {
- const size = 64 << 10
- rBuf := make([]byte, size)
- rBuf = rBuf[:runtime.Stack(rBuf, false)]
- log.Errorf("[session.handleLoop] panic session %s: err=%s\n%s", s.sessionToken(), r, rBuf)
- }
-
- grNum := atomic.AddInt32(&(s.grNum), -1)
- s.listener.OnClose(s)
- log.Infof("%s, [session.handleLoop] goroutine exit now, left gr num %d", s.Stat(), grNum)
- s.gc()
- }()
-
- wsConn, wsFlag = s.Connection.(*gettyWSConn)
-LOOP:
- for {
- select {
- case <-s.done:
- // this case branch assure the (session)handleLoop gr will exit after (session)handlePackage gr.
- <-s.rDone
- counter.Start()
- if counter.Count() > s.wait.Nanoseconds() {
- log.Infof("%s, [session.handleLoop] got done signal ", s.Stat())
- break LOOP
- }
-
- case <-wheel.After(s.period):
- if wsFlag {
- err := wsConn.writePing()
- if err != nil {
- log.Warnf("wsConn.writePing() = error:%+v", perrors.WithStack(err))
- }
- }
- s.listener.OnCron(s)
- }
+ s.grNum.Add(1)
Review comment:
move the statement `s.grNum.Add(1)` just before `go s.handlePackage()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-763774060
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc) (8b6ec17) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ef4aaa4a30bd53a8daf26e325085b4bf954d9aee?el=desc) (ef4aaa4) will **decrease** coverage by `1.35%`.
> The diff coverage is `57.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 67.89% 66.53% -1.36%
==========================================
Files 8 8
Lines 1277 1252 -25
==========================================
- Hits 867 833 -34
- Misses 318 326 +8
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `67.63% <46.66%> (-3.50%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <50.00%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree#diff-Y29ubmVjdGlvbi5nbw==) | `77.98% <86.36%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer). Last update [ef4aaa4...8b6ec17](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter commented on pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56#issuecomment-869159450
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#56](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a05931) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/30e62643dc9d44c3f10b7083ef000e5155e7f710?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30e6264) will **decrease** coverage by `1.34%`.
> The diff coverage is `59.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 68.09% 66.74% -1.35%
==========================================
Files 8 8
Lines 1285 1260 -25
==========================================
- Hits 875 841 -34
- Misses 318 326 +8
- Partials 92 93 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `67.41% <14.28%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `68.01% <48.38%> (-3.45%)` | :arrow_down: |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `65.71% <66.66%> (ø)` | |
| [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/56/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `78.22% <86.95%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30e6264...4a05931](https://codecov.io/gh/apache/dubbo-getty/pull/56?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] georgehao merged pull request #56: Ftr: delete session.handleLoop
Posted by GitBox <gi...@apache.org>.
georgehao merged pull request #56:
URL: https://github.com/apache/dubbo-getty/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org